git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] xdiff/xemit.c (xdl_find_func): Elide trailing white space in a context header.

From
Jakub Narebski <jnareb@gmail.com>
Date
Oct 23, 2006, 21:06 UTC
Message-ID
<ehjari$vda$1@sea.gmane.org>
In-Reply-To
<Pine.LNX.4.64.0610231347490.3962@g5.osdl.org>
Linus Torvalds wrote:
Show 11 quoted lines
> On Mon, 23 Oct 2006, Jim Meyering wrote:
>>
>> This removes trailing blanks from git-generated diff headers
>> the same way a similar patch did that for GNU diff:
> 
> NO!
> 
> This is _wrong_
> 
> You should only remove the space IF IT IS THE ONLY THING ON THE WHOLE 
> LINE!

If I understand the description of this patch given by the mentioned article and example therein (Jim, you should include appropriate parts of mentioned email in commit message, not just provide link to it), trailing spaces are removed from extended diff header, i.e. the "which function are we in", diff -p header. Not from diff body.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
Previous: Jakub Narebski
Message 6 of 6 in “xdiff/xemit.c (xdl_find_func): Elide trailing white space in a context header.”
  1. xdiff/xemit.c (xdl_find_func): Elide trailing white space in a context header.Jim Meyering, Oct 23, 2006
  2. Linus TorvaldsOct 23, 2006
  3. Petr BaudisOct 23, 2006
  4. Linus TorvaldsOct 23, 2006
  5. Jakub NarebskiOct 23, 2006
  6. Jakub NarebskiOct 23, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.