Re: [PATCH] xdiff/xemit.c (xdl_find_func): Elide trailing white space in a context header.

From: Petr Baudis <pasky@suse.cz>
Date: Oct 23, 2006, 21:03 UTC
Message-ID: <20061023210327.GT20017@pasky.or.cz>
In-Reply-To: <Pine.LNX.4.64.0610231347490.3962@g5.osdl.org>

Dear diary, on Mon, Oct 23, 2006 at 10:49:37PM CEST, I got a letter where Linus Torvalds <torvalds@osdl.org> said that...

Show 24 quoted lines

> 
> 
> On Mon, 23 Oct 2006, Jim Meyering wrote:
> >
> > This removes trailing blanks from git-generated diff headers
> > the same way a similar patch did that for GNU diff:
> 
> NO!
> 
> This is _wrong_
> 
> You should only remove the space IF IT IS THE ONLY THING ON THE WHOLE 
> LINE!
> 
> You must not remove white-space in general.
> 
> So the patch should check something like
> 
> 	if (len == 1 && rec[0] == ' ')
> 		len = 0;
> 
> and not like you did it.
> 
> Otherwise the patch will simply not even _apply_.

Not really - mind you, this is only about the diff headers. Actually, it is only about the hunk headers, specifically when we append the function name to the hunk header. A trailing whitespace can come out of that even if the source does not have any trailing whitespaces since we trim the line at 40 bytes.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)