Re: [PATCH] gitweb: Remove excessively redundant entries from git_difftree_body

From: Jakub Narebski <jnareb@gmail.com>
Date: Oct 1, 2006, 19:20 UTC
Message-ID: <efp4d6$a7b$1@sea.gmane.org>
In-Reply-To: <7vmz8k7nhc.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

Show 17 quoted lines

> Luben Tuikov <ltuikov@yahoo.com> writes:
> 
>> 1) All entries on the left are blobs and clicking on them
>> leads to blobs.  No more diff or blob depending on what
>> happened (modified or mode changed) to the file -- this goes
>> to the right, in the "link" column.
>>
>> 2) Remove redundant "blob" from the link column on the right.
>> This can now be had by clicking on the entry itself.
>>
>> This reduces and simplifies the code.
>>
>> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
> 
> We lost blobdiff from commitdiff page with this patch, which I
> think it probably is a good change.  We can say "when we display
> a pathname you can click it to get the blob or tree".

In my opinion it is a bad change. We now have "patch" inner-link to anchor in commitdiff view, but it's equivalent in commit view i.e. diff aka blobdiff vanished.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git