Re: [PATCH] gitweb: Remove excessively redundant entries from git_difftree_body

From: Junio C Hamano <junkio@cox.net>
Date: Sep 28, 2006, 02:07 UTC
Message-ID: <7vmz8k7nhc.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060928002325.70519.qmail@web31815.mail.mud.yahoo.com>

Luben Tuikov <ltuikov@yahoo.com> writes:

Show 11 quoted lines

> 1) All entries on the left are blobs and clicking on them
> leads to blobs.  No more diff or blob depending on what
> happened (modified or mode changed) to the file -- this goes
> to the right, in the "link" column.
>
> 2) Remove redundant "blob" from the link column on the right.
> This can now be had by clicking on the entry itself.
>
> This reduces and simplifies the code.
>
> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>

We lost blobdiff from commitdiff page with this patch, which I think it probably is a good change. We can say "when we display a pathname you can click it to get the blob or tree".

By the way, just like your "blob" and "tree" link removal, I think we can lose "commit" link in shortlog. The list looks rather cluttered with three links; we could replace it with "snapshot" link if we wanted to.

I am neutral about doing that for long log pages. The commit titles are links there as well, but they do not look like "one of the columns that can be clicked in a single line per row table" as in shortlog page. The page could also get "snapshot" links.