git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 7/7] sparse-checkout: provide a new update subcommand

From
Derrick Stolee <stolee@gmail.com>
Date
Mar 15, 2020, 16:24 UTC
Message-ID
<ee9e8bc6-252f-8ac5-e769-26302f3eb1eb@gmail.com>
In-Reply-To
<650db6863426ae2b324ba717f898247f44279cb8.1584169893.git.gitgitgadget@gmail.com>
On 3/14/2020 3:11 AM, Elijah Newren via GitGitGadget wrote:
Show 6 quoted lines
> From: Elijah Newren <newren@gmail.com>
> 
> If commands like merge or rebase materialize files as part of their work,
> or a previous sparse-checkout command failed to update individual files
> due to dirty changes, users may want a command to simply 'reapply' the
> sparsity rules.  Provide one.

I was actually thinking "refresh" would be a better name, but also you use "reapply" which is good, too. I'm concerned that "update" may imply that the sparse-checkout patterns can change, but you really mean to re-do the work from a previous "git sparse-checkout (set|add)".

I also thought of "reset" but that would be a confusing overload.
Show 50 quoted lines
> Signed-off-by: Elijah Newren <newren@gmail.com>
> ---
>  Documentation/git-sparse-checkout.txt | 10 ++++++++++
>  builtin/sparse-checkout.c             | 10 +++++++++-
>  2 files changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/git-sparse-checkout.txt b/Documentation/git-sparse-checkout.txt
> index c0342e53938..27f4392489f 100644
> --- a/Documentation/git-sparse-checkout.txt
> +++ b/Documentation/git-sparse-checkout.txt
> @@ -70,6 +70,16 @@ C-style quoted strings.
>  	`core.sparseCheckoutCone` is enabled, the given patterns are interpreted
>  	as directory names as in the 'set' subcommand.
>  
> +'update'::
> +	Update the sparseness of paths in the working tree based on the
> +	existing patterns.  Commands like merge or rebase can materialize
> +	paths to do their work (e.g. in order to show you a conflict), and
> +	other sparse-checkout commands might fail to sparsify an individual
> +	file (e.g. because it has unstaged changes or conflicts).  In such
> +	cases, it can make sense to run `git sparse-checkout update` later
> +	after cleaning up affected paths (e.g. resolving conflicts, undoing
> +	or committing changes, etc.).
> +
>  'disable'::
>  	Disable the `core.sparseCheckout` config setting, and restore the
>  	working directory to include all files. Leaves the sparse-checkout
> diff --git a/builtin/sparse-checkout.c b/builtin/sparse-checkout.c
> index 5d3ec2e6be9..2ae21011dfd 100644
> --- a/builtin/sparse-checkout.c
> +++ b/builtin/sparse-checkout.c
> @@ -18,7 +18,7 @@
>  static const char *empty_base = "";
>  
>  static char const * const builtin_sparse_checkout_usage[] = {
> -	N_("git sparse-checkout (init|list|set|add|disable) <options>"),
> +	N_("git sparse-checkout (init|list|set|add|update|disable) <options>"),
>  	NULL
>  };
>  
> @@ -552,6 +552,12 @@ static int sparse_checkout_set(int argc, const char **argv, const char *prefix,
>  	return modify_pattern_list(argc, argv, m);
>  }
>  
> +static int sparse_checkout_update(int argc, const char **argv)
> +{
> +	repo_read_index(the_repository);
> +	return update_working_directory(NULL);
> +}
> +

Short and sweet! I suppose my earlier comment about whether repo_read_index() was necessary is answered here. Perhaps it should be part of update_working_directory()? (And pass a repository pointer to it?)

Show 12 quoted lines
>  static int sparse_checkout_disable(int argc, const char **argv)
>  {
>  	struct pattern_list pl;
> @@ -601,6 +607,8 @@ int cmd_sparse_checkout(int argc, const char **argv, const char *prefix)
>  			return sparse_checkout_set(argc, argv, prefix, REPLACE);
>  		if (!strcmp(argv[0], "add"))
>  			return sparse_checkout_set(argc, argv, prefix, ADD);
> +		if (!strcmp(argv[0], "update"))
> +			return sparse_checkout_update(argc, argv);
>  		if (!strcmp(argv[0], "disable"))
>  			return sparse_checkout_disable(argc, argv);
>  	}

Thanks, -Stolee

Previous: Elijah Newren via GitGitGadgetNext: Elijah Newren
Message 3 of 69 in “Sparse checkout improvements -- improved sparsity updating”
  1. 0/7 Sparse checkout improvements -- improved sparsity updatingElijah Newren via GitGitGadget, Mar 14, 2020
  2. 7/7 sparse-checkout: provide a new update subcommandElijah Newren via GitGitGadget, Mar 14, 2020
  3. Derrick StoleeMar 15, 2020
  4. Elijah NewrenMar 16, 2020
  5. Derrick StoleeMar 16, 2020
  6. Elijah NewrenMar 16, 2020
  7. 1/7 unpack-trees: fix minor typo in commentElijah Newren via GitGitGadget, Mar 14, 2020
  8. 3/7 unpack-trees: allow check_updates() to work on a different indexElijah Newren via GitGitGadget, Mar 14, 2020
  9. 4/7 unpack-trees: do not mark a dirty path with SKIP_WORKTREEElijah Newren via GitGitGadget, Mar 14, 2020
  10. Derrick StoleeMar 15, 2020
  11. 5/7 unpack-trees: add a new update_sparsity() functionElijah Newren via GitGitGadget, Mar 14, 2020
  12. Derrick StoleeMar 15, 2020
  13. Elijah NewrenMar 16, 2020
  14. 2/7 t1091: make some tests a little more defensive against failuresElijah Newren via GitGitGadget, Mar 14, 2020
  15. 6/7 sparse-checkout: use new update_sparsity() functionElijah Newren via GitGitGadget, Mar 14, 2020
  16. Derrick StoleeMar 15, 2020
  17. Elijah NewrenMar 16, 2020
  18. Derrick StoleeMar 15, 2020
  19. 00/18 Sparse checkout improvements -- improved sparsity updatingElijah Newren via GitGitGadget, Mar 21, 2020
  20. 01/18 unpack-trees: fix minor typo in commentElijah Newren via GitGitGadget, Mar 21, 2020
  21. 03/18 unpack-trees: simplify verify_absent_sparse()Elijah Newren via GitGitGadget, Mar 21, 2020
  22. 02/18 unpack-trees: remove unused error typeElijah Newren via GitGitGadget, Mar 21, 2020
  23. 04/18 unpack-trees: simplify pattern_list freeingElijah Newren via GitGitGadget, Mar 21, 2020
  24. Derrick StoleeMar 23, 2020
  25. 06/18 unpack-trees: allow check_updates() to work on a different indexElijah Newren via GitGitGadget, Mar 21, 2020
  26. 05/18 t1091: make some tests a little more defensive against failuresElijah Newren via GitGitGadget, Mar 21, 2020
  27. 08/18 unpack-trees: pull sparse-checkout pattern reading into a new functionElijah Newren via GitGitGadget, Mar 21, 2020
  28. 09/18 unpack-trees: add a new update_sparsity() functionElijah Newren via GitGitGadget, Mar 21, 2020
  29. Derrick StoleeMar 23, 2020
  30. Elijah NewrenMar 23, 2020
  31. Derrick StoleeMar 23, 2020
  32. Junio C HamanoMar 23, 2020
  33. 11/18 sparse-checkout: use improved unpack_trees porcelain messagesElijah Newren via GitGitGadget, Mar 21, 2020
  34. 13/18 unpack-trees: rename ERROR_* fields meant for warnings to WARNING_*Elijah Newren via GitGitGadget, Mar 21, 2020
  35. 10/18 sparse-checkout: use new update_sparsity() functionElijah Newren via GitGitGadget, Mar 21, 2020
  36. Derrick StoleeMar 23, 2020
  37. Elijah NewrenMar 23, 2020
  38. Derrick StoleeMar 23, 2020
  39. 15/18 unpack-trees: make sparse path messages sound like warningsElijah Newren via GitGitGadget, Mar 21, 2020
  40. 18/18 sparse-checkout: provide a new reapply subcommandElijah Newren via GitGitGadget, Mar 21, 2020
  41. Derrick StoleeMar 23, 2020
  42. 17/18 unpack-trees: failure to set SKIP_WORKTREE bits always just a warningElijah Newren via GitGitGadget, Mar 21, 2020
  43. 14/18 unpack-trees: split display_error_msgs() into twoElijah Newren via GitGitGadget, Mar 21, 2020
  44. Derrick StoleeMar 23, 2020
  45. 16/18 unpack-trees: provide warnings on sparse updates for unmerged paths tooElijah Newren via GitGitGadget, Mar 21, 2020
  46. 07/18 unpack-trees: do not mark a dirty path with SKIP_WORKTREEElijah Newren via GitGitGadget, Mar 21, 2020
  47. 12/18 unpack-trees: move ERROR_WOULD_LOSE_SUBMODULE earlierElijah Newren via GitGitGadget, Mar 21, 2020
  48. Derrick StoleeMar 23, 2020
  49. Junio C HamanoMar 23, 2020
  50. 00/18 Sparse checkout improvements -- improved sparsity updatingElijah Newren via GitGitGadget, Mar 27, 2020
  51. 01/18 unpack-trees: fix minor typo in commentElijah Newren via GitGitGadget, Mar 27, 2020
  52. 02/18 unpack-trees: remove unused error typeElijah Newren via GitGitGadget, Mar 27, 2020
  53. 06/18 unpack-trees: allow check_updates() to work on a different indexElijah Newren via GitGitGadget, Mar 27, 2020
  54. 04/18 unpack-trees: simplify pattern_list freeingElijah Newren via GitGitGadget, Mar 27, 2020
  55. 05/18 t1091: make some tests a little more defensive against failuresElijah Newren via GitGitGadget, Mar 27, 2020
  56. 03/18 unpack-trees: simplify verify_absent_sparse()Elijah Newren via GitGitGadget, Mar 27, 2020
  57. 07/18 unpack-trees: do not mark a dirty path with SKIP_WORKTREEElijah Newren via GitGitGadget, Mar 27, 2020
  58. 08/18 unpack-trees: pull sparse-checkout pattern reading into a new functionElijah Newren via GitGitGadget, Mar 27, 2020
  59. 09/18 unpack-trees: add a new update_sparsity() functionElijah Newren via GitGitGadget, Mar 27, 2020
  60. 10/18 sparse-checkout: use new update_sparsity() functionElijah Newren via GitGitGadget, Mar 27, 2020
  61. 11/18 sparse-checkout: use improved unpack_trees porcelain messagesElijah Newren via GitGitGadget, Mar 27, 2020
  62. 13/18 unpack-trees: rename ERROR_* fields meant for warnings to WARNING_*Elijah Newren via GitGitGadget, Mar 27, 2020
  63. 16/18 unpack-trees: provide warnings on sparse updates for unmerged paths tooElijah Newren via GitGitGadget, Mar 27, 2020
  64. 18/18 sparse-checkout: provide a new reapply subcommandElijah Newren via GitGitGadget, Mar 27, 2020
  65. 15/18 unpack-trees: make sparse path messages sound like warningsElijah Newren via GitGitGadget, Mar 27, 2020
  66. 14/18 unpack-trees: split display_error_msgs() into twoElijah Newren via GitGitGadget, Mar 27, 2020
  67. 17/18 unpack-trees: failure to set SKIP_WORKTREE bits always just a warningElijah Newren via GitGitGadget, Mar 27, 2020
  68. 12/18 unpack-trees: move ERROR_WOULD_LOSE_SUBMODULE earlierElijah Newren via GitGitGadget, Mar 27, 2020
  69. Derrick StoleeMar 27, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.