git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 00/18] Sparse checkout improvements -- improved sparsity updating

From
Derrick Stolee <stolee@gmail.com>
Date
Mar 27, 2020, 13:22 UTC
Message-ID
<9f33833a-43e3-8878-859d-1c116a54de97@gmail.com>
In-Reply-To
<pull.726.v3.git.git.1585270142.gitgitgadget@gmail.com>
On 3/26/2020 8:48 PM, Elijah Newren via GitGitGadget wrote:
Show 11 quoted lines
> This series provides a replacement for the sparsity updating in
> sparse-checkout that is based on the logic from git read-tree -mu HEAD. The
> most important bit is patch 9 and its lengthy commit message explaining the
> current state and rationale for most the series, though patches 16 and 17
> have additional related directions and rationale for the series. Those three
> patches are the most important to review.
> 
> Changes since v2:
> 
>  * addressed Stolee's cleanups and added his Reviewed-by to the series
>    (hopefully the next two changes don't invalidate that)
The other changes below look good to me. My Reviewed-by stands.
Show 7 quoted lines
>  * added a test for the new 'reapply' subcommand (noticed it was missing
>    with Stolee's test coverage report)
>  * fix a minor issue with two of the other tests I modified -- when I'm
>    grepping through stderr for a command, I need to make sure to actually
>    record stderr from that command (otherwise my grep is looking through the
>    stderr of a previous command that was recorded). Also, since I messed
>    this up, I added one or two more sanity checks while I was at it.
Thanks!
-Stolee
Previous: Elijah Newren via GitGitGadget
Message 69 of 69 in “Sparse checkout improvements -- improved sparsity updating”
  1. 0/7 Sparse checkout improvements -- improved sparsity updatingElijah Newren via GitGitGadget, Mar 14, 2020
  2. 7/7 sparse-checkout: provide a new update subcommandElijah Newren via GitGitGadget, Mar 14, 2020
  3. Derrick StoleeMar 15, 2020
  4. Elijah NewrenMar 16, 2020
  5. Derrick StoleeMar 16, 2020
  6. Elijah NewrenMar 16, 2020
  7. 1/7 unpack-trees: fix minor typo in commentElijah Newren via GitGitGadget, Mar 14, 2020
  8. 3/7 unpack-trees: allow check_updates() to work on a different indexElijah Newren via GitGitGadget, Mar 14, 2020
  9. 4/7 unpack-trees: do not mark a dirty path with SKIP_WORKTREEElijah Newren via GitGitGadget, Mar 14, 2020
  10. Derrick StoleeMar 15, 2020
  11. 5/7 unpack-trees: add a new update_sparsity() functionElijah Newren via GitGitGadget, Mar 14, 2020
  12. Derrick StoleeMar 15, 2020
  13. Elijah NewrenMar 16, 2020
  14. 2/7 t1091: make some tests a little more defensive against failuresElijah Newren via GitGitGadget, Mar 14, 2020
  15. 6/7 sparse-checkout: use new update_sparsity() functionElijah Newren via GitGitGadget, Mar 14, 2020
  16. Derrick StoleeMar 15, 2020
  17. Elijah NewrenMar 16, 2020
  18. Derrick StoleeMar 15, 2020
  19. 00/18 Sparse checkout improvements -- improved sparsity updatingElijah Newren via GitGitGadget, Mar 21, 2020
  20. 01/18 unpack-trees: fix minor typo in commentElijah Newren via GitGitGadget, Mar 21, 2020
  21. 03/18 unpack-trees: simplify verify_absent_sparse()Elijah Newren via GitGitGadget, Mar 21, 2020
  22. 02/18 unpack-trees: remove unused error typeElijah Newren via GitGitGadget, Mar 21, 2020
  23. 04/18 unpack-trees: simplify pattern_list freeingElijah Newren via GitGitGadget, Mar 21, 2020
  24. Derrick StoleeMar 23, 2020
  25. 06/18 unpack-trees: allow check_updates() to work on a different indexElijah Newren via GitGitGadget, Mar 21, 2020
  26. 05/18 t1091: make some tests a little more defensive against failuresElijah Newren via GitGitGadget, Mar 21, 2020
  27. 08/18 unpack-trees: pull sparse-checkout pattern reading into a new functionElijah Newren via GitGitGadget, Mar 21, 2020
  28. 09/18 unpack-trees: add a new update_sparsity() functionElijah Newren via GitGitGadget, Mar 21, 2020
  29. Derrick StoleeMar 23, 2020
  30. Elijah NewrenMar 23, 2020
  31. Derrick StoleeMar 23, 2020
  32. Junio C HamanoMar 23, 2020
  33. 11/18 sparse-checkout: use improved unpack_trees porcelain messagesElijah Newren via GitGitGadget, Mar 21, 2020
  34. 13/18 unpack-trees: rename ERROR_* fields meant for warnings to WARNING_*Elijah Newren via GitGitGadget, Mar 21, 2020
  35. 10/18 sparse-checkout: use new update_sparsity() functionElijah Newren via GitGitGadget, Mar 21, 2020
  36. Derrick StoleeMar 23, 2020
  37. Elijah NewrenMar 23, 2020
  38. Derrick StoleeMar 23, 2020
  39. 15/18 unpack-trees: make sparse path messages sound like warningsElijah Newren via GitGitGadget, Mar 21, 2020
  40. 18/18 sparse-checkout: provide a new reapply subcommandElijah Newren via GitGitGadget, Mar 21, 2020
  41. Derrick StoleeMar 23, 2020
  42. 17/18 unpack-trees: failure to set SKIP_WORKTREE bits always just a warningElijah Newren via GitGitGadget, Mar 21, 2020
  43. 14/18 unpack-trees: split display_error_msgs() into twoElijah Newren via GitGitGadget, Mar 21, 2020
  44. Derrick StoleeMar 23, 2020
  45. 16/18 unpack-trees: provide warnings on sparse updates for unmerged paths tooElijah Newren via GitGitGadget, Mar 21, 2020
  46. 07/18 unpack-trees: do not mark a dirty path with SKIP_WORKTREEElijah Newren via GitGitGadget, Mar 21, 2020
  47. 12/18 unpack-trees: move ERROR_WOULD_LOSE_SUBMODULE earlierElijah Newren via GitGitGadget, Mar 21, 2020
  48. Derrick StoleeMar 23, 2020
  49. Junio C HamanoMar 23, 2020
  50. 00/18 Sparse checkout improvements -- improved sparsity updatingElijah Newren via GitGitGadget, Mar 27, 2020
  51. 01/18 unpack-trees: fix minor typo in commentElijah Newren via GitGitGadget, Mar 27, 2020
  52. 02/18 unpack-trees: remove unused error typeElijah Newren via GitGitGadget, Mar 27, 2020
  53. 06/18 unpack-trees: allow check_updates() to work on a different indexElijah Newren via GitGitGadget, Mar 27, 2020
  54. 04/18 unpack-trees: simplify pattern_list freeingElijah Newren via GitGitGadget, Mar 27, 2020
  55. 05/18 t1091: make some tests a little more defensive against failuresElijah Newren via GitGitGadget, Mar 27, 2020
  56. 03/18 unpack-trees: simplify verify_absent_sparse()Elijah Newren via GitGitGadget, Mar 27, 2020
  57. 07/18 unpack-trees: do not mark a dirty path with SKIP_WORKTREEElijah Newren via GitGitGadget, Mar 27, 2020
  58. 08/18 unpack-trees: pull sparse-checkout pattern reading into a new functionElijah Newren via GitGitGadget, Mar 27, 2020
  59. 09/18 unpack-trees: add a new update_sparsity() functionElijah Newren via GitGitGadget, Mar 27, 2020
  60. 10/18 sparse-checkout: use new update_sparsity() functionElijah Newren via GitGitGadget, Mar 27, 2020
  61. 11/18 sparse-checkout: use improved unpack_trees porcelain messagesElijah Newren via GitGitGadget, Mar 27, 2020
  62. 13/18 unpack-trees: rename ERROR_* fields meant for warnings to WARNING_*Elijah Newren via GitGitGadget, Mar 27, 2020
  63. 16/18 unpack-trees: provide warnings on sparse updates for unmerged paths tooElijah Newren via GitGitGadget, Mar 27, 2020
  64. 18/18 sparse-checkout: provide a new reapply subcommandElijah Newren via GitGitGadget, Mar 27, 2020
  65. 15/18 unpack-trees: make sparse path messages sound like warningsElijah Newren via GitGitGadget, Mar 27, 2020
  66. 14/18 unpack-trees: split display_error_msgs() into twoElijah Newren via GitGitGadget, Mar 27, 2020
  67. 17/18 unpack-trees: failure to set SKIP_WORKTREE bits always just a warningElijah Newren via GitGitGadget, Mar 27, 2020
  68. 12/18 unpack-trees: move ERROR_WOULD_LOSE_SUBMODULE earlierElijah Newren via GitGitGadget, Mar 27, 2020
  69. Derrick StoleeMar 27, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.