git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 6/6] read-cache: fix GIT_TEST_SPLIT_INDEX

From
Derrick Stolee <stolee@gmail.com>
Date
Aug 17, 2021, 18:29 UTC
Message-ID
<edd7b53e-f0e9-b56c-e13d-63a2f963b703@gmail.com>
In-Reply-To
<20210817174938.3009923-7-szeder.dev@gmail.com>
On 8/17/2021 1:49 PM, SZEDER Gábor wrote:

Sorry to crop all of your excellent description of why this wasn't working before and why it will work now, but...

Show 11 quoted lines
> +test_expect_success 'GIT_TEST_SPLIT_INDEX works' '
> +	git init git-test-split-index &&
> +	(
> +		cd git-test-split-index &&
> +		>file &&
> +		GIT_TEST_SPLIT_INDEX=1 git update-index --add file &&
> +		ls -l .git/sharedindex.* >actual &&
> +		test_line_count = 1 actual
> +	)
> +'
> +

This is really the critical piece to ensure we don't have a similar problem in the future. Thanks!

-Stolee
Previous: SZEDER GáborNext: SZEDER Gábor
Message 14 of 23 in “Fix GIT_TEST_SPLIT_INDEX”
  1. 0/6 Fix GIT_TEST_SPLIT_INDEXSZEDER Gábor, Aug 17, 2021
  2. 1/6 t1600-index: remove unnecessary redirectionSZEDER Gábor, Aug 17, 2021
  3. Derrick StoleeAug 17, 2021
  4. SZEDER GáborAug 17, 2021
  5. Derrick StoleeAug 17, 2021
  6. 2/6 t1600-index: don't run git commands upstream of a pipeSZEDER Gábor, Aug 17, 2021
  7. 3/6 t1600-index: disable GIT_TEST_SPLIT_INDEXSZEDER Gábor, Aug 17, 2021
  8. 4/6 read-cache: look for shared index files next to the index, tooSZEDER Gábor, Aug 17, 2021
  9. 5/6 tests: disable GIT_TEST_SPLIT_INDEX for sparse index testsSZEDER Gábor, Aug 17, 2021
  10. Derrick StoleeAug 17, 2021
  11. SZEDER GáborAug 17, 2021
  12. Derrick StoleeAug 18, 2021
  13. 6/6 read-cache: fix GIT_TEST_SPLIT_INDEXSZEDER Gábor, Aug 17, 2021
  14. Derrick StoleeAug 17, 2021
  15. 0/6 Fix GIT_TEST_SPLIT_INDEXSZEDER Gábor, Aug 26, 2021
  16. 1/6 t1600-index: remove unnecessary redirectionSZEDER Gábor, Aug 26, 2021
  17. 2/6 t1600-index: don't run git commands upstream of a pipeSZEDER Gábor, Aug 26, 2021
  18. 3/6 t1600-index: disable GIT_TEST_SPLIT_INDEXSZEDER Gábor, Aug 26, 2021
  19. 4/6 read-cache: look for shared index files next to the index, tooSZEDER Gábor, Aug 26, 2021
  20. 6/6 read-cache: fix GIT_TEST_SPLIT_INDEXSZEDER Gábor, Aug 26, 2021
  21. 5/6 tests: disable GIT_TEST_SPLIT_INDEX for sparse index testsSZEDER Gábor, Aug 26, 2021
  22. Derrick StoleeAug 31, 2021
  23. Junio C HamanoAug 31, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.