git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/6] t1600-index: don't run git commands upstream of a pipe

From
SZEDER Gábor <szeder.dev@gmail.com>
Date
Aug 17, 2021, 17:49 UTC
Message-ID
<20210817174938.3009923-3-szeder.dev@gmail.com>
In-Reply-To
<20210817174938.3009923-1-szeder.dev@gmail.com>
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
---
 t/t1600-index.sh | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/t/t1600-index.sh b/t/t1600-index.sh
index 5d10cec67a..aa88fc30ce 100755
--- a/t/t1600-index.sh
+++ b/t/t1600-index.sh
@@ -13,7 +13,8 @@ test_expect_success 'bogus GIT_INDEX_VERSION issues warning' '
 		rm -f .git/index &&
 		GIT_INDEX_VERSION=2bogus &&
 		export GIT_INDEX_VERSION &&
-		git add a 2>&1 | sed "s/[0-9]//" >actual.err &&
+		git add a 2>err &&
+		sed "s/[0-9]//" err >actual.err &&
 		sed -e "s/ Z$/ /" <<-\EOF >expect.err &&
 			warning: GIT_INDEX_VERSION set, but the value is invalid.
 			Using version Z
@@ -27,7 +28,8 @@ test_expect_success 'out of bounds GIT_INDEX_VERSION issues warning' '
 		rm -f .git/index &&
 		GIT_INDEX_VERSION=1 &&
 		export GIT_INDEX_VERSION &&
-		git add a 2>&1 | sed "s/[0-9]//" >actual.err &&
+		git add a 2>err &&
+		sed "s/[0-9]//" err >actual.err &&
 		sed -e "s/ Z$/ /" <<-\EOF >expect.err &&
 			warning: GIT_INDEX_VERSION set, but the value is invalid.
 			Using version Z
@@ -50,7 +52,8 @@ test_expect_success 'out of bounds index.version issues warning' '
 		sane_unset GIT_INDEX_VERSION &&
 		rm -f .git/index &&
 		git config --add index.version 1 &&
-		git add a 2>&1 | sed "s/[0-9]//" >actual.err &&
+		git add a 2>err &&
+		sed "s/[0-9]//" err >actual.err &&
 		sed -e "s/ Z$/ /" <<-\EOF >expect.err &&
 			warning: index.version set, but the value is invalid.
 			Using version Z
-- 
2.33.0.453.gc5e41af357
Previous: Derrick StoleeNext: SZEDER Gábor
Message 6 of 23 in “Fix GIT_TEST_SPLIT_INDEX”
  1. 0/6 Fix GIT_TEST_SPLIT_INDEXSZEDER Gábor, Aug 17, 2021
  2. 1/6 t1600-index: remove unnecessary redirectionSZEDER Gábor, Aug 17, 2021
  3. Derrick StoleeAug 17, 2021
  4. SZEDER GáborAug 17, 2021
  5. Derrick StoleeAug 17, 2021
  6. 2/6 t1600-index: don't run git commands upstream of a pipeSZEDER Gábor, Aug 17, 2021
  7. 3/6 t1600-index: disable GIT_TEST_SPLIT_INDEXSZEDER Gábor, Aug 17, 2021
  8. 4/6 read-cache: look for shared index files next to the index, tooSZEDER Gábor, Aug 17, 2021
  9. 5/6 tests: disable GIT_TEST_SPLIT_INDEX for sparse index testsSZEDER Gábor, Aug 17, 2021
  10. Derrick StoleeAug 17, 2021
  11. SZEDER GáborAug 17, 2021
  12. Derrick StoleeAug 18, 2021
  13. 6/6 read-cache: fix GIT_TEST_SPLIT_INDEXSZEDER Gábor, Aug 17, 2021
  14. Derrick StoleeAug 17, 2021
  15. 0/6 Fix GIT_TEST_SPLIT_INDEXSZEDER Gábor, Aug 26, 2021
  16. 1/6 t1600-index: remove unnecessary redirectionSZEDER Gábor, Aug 26, 2021
  17. 2/6 t1600-index: don't run git commands upstream of a pipeSZEDER Gábor, Aug 26, 2021
  18. 3/6 t1600-index: disable GIT_TEST_SPLIT_INDEXSZEDER Gábor, Aug 26, 2021
  19. 4/6 read-cache: look for shared index files next to the index, tooSZEDER Gábor, Aug 26, 2021
  20. 6/6 read-cache: fix GIT_TEST_SPLIT_INDEXSZEDER Gábor, Aug 26, 2021
  21. 5/6 tests: disable GIT_TEST_SPLIT_INDEX for sparse index testsSZEDER Gábor, Aug 26, 2021
  22. Derrick StoleeAug 31, 2021
  23. Junio C HamanoAug 31, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.