[PATCH 4/4] midx.c: guard against commit_lock_file() failures
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Oct 8, 2021, 21:46 UTC
- Message-ID
- <ed7407cefa89b973d1085973f4ddb39397597036.1633729502.git.me@ttaylorr.com>
- In-Reply-To
- <cover.1633729502.git.me@ttaylorr.com>
When writing a MIDX, we atomically move the new MIDX into place via commit_lock_file(), but do not check to see if that call was successful.
Make sure that we do check in order to prevent us from incorrectly reporting that we wrote a new MIDX if we actually encountered an error.
Signed-off-by: Taylor Blau <me@ttaylorr.com> --- midx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/midx.c b/midx.c index 137af3fc67..e79fb4427d 100644 --- a/midx.c +++ b/midx.c @@ -1434,7 +1434,8 @@ static int write_midx_internal(const char *object_dir, if (ctx.m) close_object_store(the_repository->objects); - commit_lock_file(&lk); + if (commit_lock_file(&lk) < 0) + die_errno(_("could not write multi-pack-index")); clear_midx_files_ext(object_dir, ".bitmap", midx_hash); clear_midx_files_ext(object_dir, ".rev", midx_hash);
-- 2.33.0.96.g73915697e6