git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/4] midx.c: lookup MIDX by object directory during repack

From
Taylor Blau <me@ttaylorr.com>
Date
Oct 8, 2021, 21:46 UTC
Message-ID
<0accab9139e095c10bf6f299b77bab048e2b4c77.1633729502.git.me@ttaylorr.com>
In-Reply-To
<cover.1633729502.git.me@ttaylorr.com>

Apply similar treatment as in the last commit to the MIDX `repack` operation.

Signed-off-by: Taylor Blau <me@ttaylorr.com>
---
 midx.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/midx.c b/midx.c
index 7f1addf4b6..137af3fc67 100644
--- a/midx.c
+++ b/midx.c
@@ -1872,7 +1872,7 @@ int midx_repack(struct repository *r, const char *object_dir, size_t batch_size,
 	struct child_process cmd = CHILD_PROCESS_INIT;
 	FILE *cmd_in;
 	struct strbuf base_name = STRBUF_INIT;
-	struct multi_pack_index *m = load_multi_pack_index(object_dir, 1);
+	struct multi_pack_index *m = lookup_multi_pack_index(r, object_dir);
 
 	/*
 	 * When updating the default for these configuration
@@ -1944,11 +1944,8 @@ int midx_repack(struct repository *r, const char *object_dir, size_t batch_size,
 	}
 
 	result = write_midx_internal(object_dir, NULL, NULL, NULL, NULL, flags);
-	m = NULL;
 
 cleanup:
-	if (m)
-		close_midx(m);
 	free(include_pack);
 	return result;
 }
-- 
2.33.0.96.g73915697e6
Previous: Derrick StoleeNext: Taylor Blau
Message 5 of 8 in “midx: avoid potential rename-while-mapped on Windows”
  1. 0/4 midx: avoid potential rename-while-mapped on WindowsTaylor Blau, Oct 8, 2021
  2. 1/4 midx.c: extract MIDX lookup by object_dirTaylor Blau, Oct 8, 2021
  3. 2/4 midx.c: lookup MIDX by object directory during expireTaylor Blau, Oct 8, 2021
  4. Derrick StoleeOct 13, 2021
  5. 3/4 midx.c: lookup MIDX by object directory during repackTaylor Blau, Oct 8, 2021
  6. 4/4 midx.c: guard against commit_lock_file() failuresTaylor Blau, Oct 8, 2021
  7. Ævar Arnfjörð BjarmasonOct 9, 2021
  8. Derrick StoleeOct 13, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.