Re: [PATCH 0/3] builtin/commit-graph.c: new split/merge options

From: Derrick Stolee <stolee@gmail.com>
Date: Jan 31, 2020, 13:26 UTC
Message-ID: <ecb789c0-1a6e-244d-1b7f-de136e0173d2@gmail.com>
In-Reply-To: <20200131003210.GA91635@syl.local>

On 1/30/2020 7:32 PM, Taylor Blau wrote:

Show 21 quoted lines

> On Thu, Jan 30, 2020 at 04:28:14PM -0800, Taylor Blau wrote:
>> Hi,
>>
>> Here are another few patches that came out of working on GitHub's
>> deployment of incremental commit-graphs. These three patches introduce
>> two new options: '--split[=<merge-all|no-merge>]' and
>> '--input=<source>'.
> 
> I should have mentioned: these patches are based on top of my
> 'tb/commit-graph-use-odb' branch, which I sent to the list in:
> 
>   https://lore.kernel.org/git/cover.1580424766.git.me@ttaylorr.com
> 
> I think that it makes sense to queue the above other topic first before
> this one is applied, at least since these patches are based on that
> branch. I can prepare a version that is based on 'master' if that is
> preferable, there are only a handful of conflicts to resolve around use
> of '->obj_dir' vs '->odb->path' in changing the order.
> 
> The two just felt a little too large and disjoint to send as one larger
> series.

I think the order you recommend is good, especially because the obj_dir cleanup is less likely to be controversial. Command-line interface changes should have more time to cook.

Thanks, -Stolee