Re: [PATCH v2 3/3] builtin/commit-graph.c: support '--input=none'

From: Martin Ågren <martin.agren@gmail.com>
Date: Feb 6, 2020, 19:50 UTC
Message-ID: <CAN0heSrRJYc8DoWQ+NHR5LJ1z7d1GGBni2waP0_Lv7gMYjPPEg@mail.gmail.com>
In-Reply-To: <4c6425f0da9a6e5ae86530a12f18959ada07404b.1580862307.git.me@ttaylorr.com>

On Wed, 5 Feb 2020 at 01:28, Taylor Blau <me@ttaylorr.com> wrote:

Show 7 quoted lines

> @@ -57,6 +57,12 @@ walking commits starting at all refs. (Cannot be combined with
>  With the `--input=append` option, include all commits that are present
>  in the existing commit-graph file.
>  +
> +With the `--input=none` option, behave as if `--input=append` were
> +given, but do not walk other packs to find additional commits.
> +

Similar to my comment in patch 1/3. Please add a "+" instead of an empty line. This one actually trips up the rendering quite a bit of a lot of what follows.

> +If none of the above options are given, then generate the new
> +commit-graph by walking over all pack-indexes.
> ++

This one's good.

Martin