Re: [PATCH] CodingGuidelines: !! is not all that exotic
Hi Junio
On 18/11/2026 18:31, Junio C Hamano wrote:
Show 10 quoted lines
> Remove the clause against "clever tricks" that cites !!value that is
> a standard technique to normalize a value to 0/1 boolean. We could
> resurrect it if we can come up with a truly exotic example that we
> would want to avoid, but this is not a good enough justification for
> this rule.
> > Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> * I think we saw a good example that !! was used in a recent review
> thread, and the idea to remove this rule was floated back then,
> but without following through.
Yes, its come up a couple of times recently, thanks for putting a patch together.
Phillip
Show 16 quoted lines
> Documentation/CodingGuidelines | 4 ----
> 1 file changed, 4 deletions(-)
> > diff --git c/Documentation/CodingGuidelines w/Documentation/CodingGuidelines
> index 3c8d6c7dd3..4bfa615bac 100644
> --- c/Documentation/CodingGuidelines
> +++ w/Documentation/CodingGuidelines
> @@ -522,10 +522,6 @@ For C programs:
> that_is_used_in + a_very_long_expression) {
> ...
> > - - Some clever tricks, like using the !! operator with arithmetic
> - constructs, can be extremely confusing to others. Avoid them,
> - unless there is a compelling reason to use them.
> -
> - Use the API. No, really. We have a strbuf (variable length
> string), several arrays with the ALLOC_GROW() macro, a
> string_list for sorted string lists, a hash map (mapping struct