git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] CodingGuidelines: !! is not all that exotic

From
KHKristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date
Nov 19, 2026, 15:15 UTC
Message-ID
<b0e1d692-0be0-4453-97f2-c6581630b9e9@app.fastmail.com>
In-Reply-To
<xmqq33sy6lgb.fsf@gitster.g>
On Wed, Nov 18, 2026, at 19:31, Junio C Hamano wrote:
Show 30 quoted lines
> Remove the clause against "clever tricks" that cites !!value that is
> a standard technique to normalize a value to 0/1 boolean.  We could
> resurrect it if we can come up with a truly exotic example that we
> would want to avoid, but this is not a good enough justification for
> this rule.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>  * I think we saw a good example that !! was used in a recent review
>    thread, and the idea to remove this rule was floated back then,
>    but without following through.
>
>  Documentation/CodingGuidelines | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git c/Documentation/CodingGuidelines w/Documentation/CodingGuidelines
> index 3c8d6c7dd3..4bfa615bac 100644
> --- c/Documentation/CodingGuidelines
> +++ w/Documentation/CodingGuidelines
> @@ -522,10 +522,6 @@ For C programs:
>  	    that_is_used_in + a_very_long_expression) {
>  		...
>
> - - Some clever tricks, like using the !! operator with arithmetic
> -   constructs, can be extremely confusing to others.  Avoid them,
> -   unless there is a compelling reason to use them.
> -
>   - Use the API.  No, really.  We have a strbuf (variable length
>     string), several arrays with the ALLOC_GROW() macro, a
>     string_list for sorted string lists, a hash map (mapping struct

I wondered why this was added in the first place. But this dates back to 6d0618a8 (Add Documentation/CodingGuidelines, 2007-11-08). So it was there from the start. And you objected to it on the first version:

https://lore.kernel.org/git/7v640ega5q.fsf@gitster.siamese.dyndns.org/

JC> I actually think (!!var) idiom is already established in our JC> codebase.

Andreas Ericsson replied and emphasized *arithmetic expressions*, which I guess means that it is not just a single expression normalized to a boolean.

AE> Not very widely for arithmetic expressions though. I believe this AE> alludes to the (!!a + !!b + !!c) idiom used earlier, where it's not AE> exactly clear *why* a, b and c can be > 1 if != 0 is the only thing AE> we care about.

Previous: Phillip Wood
Message 3 of 3 in “CodingGuidelines: !! is not all that exotic”
  1. CodingGuidelines: !! is not all that exoticJunio C Hamano, Nov 18, 2026
  2. Phillip WoodNov 19, 2026
  3. Kristoffer HaugsbakkNov 19, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.