Re: [PATCH/RFC] gitweb: Great subroutines renaming

From: Jakub Narebski <jnareb@gmail.com>
Date: Aug 8, 2006, 20:24 UTC
Message-ID: <ebaru7$951$1@sea.gmane.org>
In-Reply-To: <7voduvugl9.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

> Jakub Narebski <jnareb@gmail.com> writes:
>

Show 8 quoted lines

>> Wouldn't it be better to (re)use notation of rpm's --query-format, 
>> i.e. use %{name}, or %30{name}, or %-30{name} for single scalar values,
>> use :typetag output formats,...
> 
> I did not do them because these enhancements are not needed to
> unblock you from optimizing git_get_* calls in gitweb.  These
> enhancement can come later as long as the initial syntax is
> simple, clean and extensible enough, which I think it is.

Yes, that's true. I'm wondering if %(fieldname) of %{fieldname} would be better.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git