Re: [PATCH/RFC] gitweb: Great subroutines renaming

From: Junio C Hamano <junkio@cox.net>
Date: Aug 8, 2006, 20:18 UTC
Message-ID: <7voduvugl9.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <eb9m30$3ef$2@sea.gmane.org>

Jakub Narebski <jnareb@gmail.com> writes:

> `git-ls-remotes .` is suspiciously missing from the examples.

Because the point of show-refs was not to replace it only for the local case.

> Format needs to somewhat incorporate line for referencing object for that, 
> if it exists.

Also I do not think you would want "ref^{}" style dereferencing ls-remotes does for gitweb anyway.

What gitweb might want is "what type of object is this tag pointing at" and "what is the object pointed at by this tag" (both used on "Tags" list). I think show-refs specification allows you to do that inexpensively.

> Wouldn't it be better to (re)use notation of rpm's --query-format, 
> i.e. use %{name}, or %30{name}, or %-30{name} for single scalar values,
> use :typetag output formats,...

I did not do them because these enhancements are not needed to unblock you from optimizing git_get_* calls in gitweb. These enhancement can come later as long as the initial syntax is simple, clean and extensible enough, which I think it is.