Re: [PATCH v5 24/24] t1406: new tests for submodule ref store

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Mar 3, 2017, 16:51 UTC
Message-ID: <eb088421-11c1-a6d7-398e-b2b8b4d785e3@alum.mit.edu>
In-Reply-To: <20170222140450.30886-25-pclouds@gmail.com>

On 02/22/2017 03:04 PM, Nguyễn Thái Ngọc Duy wrote:

Show 5 quoted lines

> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  t/t1406-submodule-ref-store.sh (new +x) | 95 +++++++++++++++++++++++++++++++++
>  1 file changed, 95 insertions(+)
>  create mode 100755 t/t1406-submodule-ref-store.sh

I wonder if you could reduce some of the repetition between this test file and t1405, at least for the functions that should work for both the main repository and for submodules? For example, if you were to define

    GIT='git'

in one case and

    GIT='git -C sub'

in the other, then maybe some of the setup code could be made to look alike? Then the division could be one test file for the functions that work for both main and submodules, and a second for the functions that only work for main. Just a thought...

Michael