Re: [PATCH 06/11] refs-internal.h: correct is_per_worktree_ref()

From: Stefan Beller <sbeller@google.com>
Date: Feb 13, 2017, 22:37 UTC
Message-ID: <CAGZ79kYkc-_=RiK1uJ+ndhQu=B8u=UDVusXZu-dYe7KnGNye3Q@mail.gmail.com>
In-Reply-To: <20170213152011.12050-7-pclouds@gmail.com>

On Mon, Feb 13, 2017 at 7:20 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

Show 18 quoted lines

> All refs outside refs/ directory is per-worktree, not just HEAD.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  refs/refs-internal.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/refs/refs-internal.h b/refs/refs-internal.h
> index f4aed49f5..69d02b6ba 100644
> --- a/refs/refs-internal.h
> +++ b/refs/refs-internal.h
> @@ -653,7 +653,7 @@ const char *resolve_ref_recursively(struct ref_store *refs,
>
>  static inline int is_per_worktree_ref(const char *refname)
>  {
> -       return !strcmp(refname, "HEAD") ||
> +       return !starts_with(refname, "refs/") ||
>                 starts_with(refname, "refs/bisect/");

you're loosing HEAD here? (assuming we get HEAD in short form here, as well as long form refs/HEAD)

Show 5 quoted lines

>  }
>
> --
> 2.11.0.157.gd943d85
>