git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 4/9] SubmittingPatches: discourage new trailers

From
Josh Soref via GitGitGadget <gitgitgadget@gmail.com>
Date
Dec 21, 2023, 16:41 UTC
Message-ID
<eac2211332f754c5f4127a58aafb9882bfe939e8.1703176866.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1623.v2.git.1703176865.gitgitgadget@gmail.com>
From: Josh Soref <jsoref@gmail.com>

There seems to be consensus amongst the core Git community on a working set of common trailers, and there are non-trivial costs to people inventing new trailers (research to discover what they mean/how they differ from existing trailers) such that inventing new ones is generally unwarranted and not something to be recommended to new contributors.

Suggested-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
---
 Documentation/SubmittingPatches | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 32e90238777..58dfe405049 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -356,8 +356,9 @@ If you like, you can put extra tags at the end:
 . `Tested-by:` is used to indicate that the person applied the patch
   and found it to have the desired effect.
 
-You can also create your own tag or use one that's in common usage
-such as "Thanks-to:", "Based-on-patch-by:", or "Mentored-by:".
+While you can also create your own trailer if the situation warrants it, we
+encourage you to instead use one of the common trailers in this project
+highlighted above.
 
 [[git-tools]]
 === Generate your patch using Git tools out of your commits.
-- 
gitgitgadget
Previous: Junio C HamanoNext: Josh Soref via GitGitGadget
Message 36 of 55 in “Minor improvements to CodingGuidelines and SubmittingPatches”
  1. 0/8 Minor improvements to CodingGuidelines and SubmittingPatchesJosh Soref via GitGitGadget, Dec 19, 2023
  2. 1/8 CodingGuidelines: move period inside parenthesesJosh Soref via GitGitGadget, Dec 19, 2023
  3. 2/8 CodingGuidelines: write punctuation marksJosh Soref via GitGitGadget, Dec 19, 2023
  4. 3/8 SubmittingPatches: drop ref to "What's in git.git"Josh Soref via GitGitGadget, Dec 19, 2023
  5. 4/8 SubmittingPatches: update extra tags listJosh Soref via GitGitGadget, Dec 19, 2023
  6. Phillip WoodDec 20, 2023
  7. Elijah NewrenDec 20, 2023
  8. Josh SorefDec 20, 2023
  9. Elijah NewrenDec 20, 2023
  10. Josh SorefDec 20, 2023
  11. phillip.wood123@gmail.comDec 21, 2023
  12. Junio C HamanoDec 20, 2023
  13. 5/8 SubmittingPatches: improve extra tags adviceJosh Soref via GitGitGadget, Dec 19, 2023
  14. 6/8 SubmittingPatches: clarify GitHub visualJosh Soref via GitGitGadget, Dec 19, 2023
  15. René ScharfeDec 19, 2023
  16. Elijah NewrenDec 20, 2023
  17. Josh SorefDec 20, 2023
  18. Junio C HamanoDec 20, 2023
  19. 7/8 SubmittingPatches: clarify GitHub artifact formatJosh Soref via GitGitGadget, Dec 19, 2023
  20. Elijah NewrenDec 20, 2023
  21. Josh SorefDec 20, 2023
  22. Elijah NewrenDec 20, 2023
  23. 8/8 SubmittingPatches: hyphenate non-ASCIIJosh Soref via GitGitGadget, Dec 19, 2023
  24. Elijah NewrenDec 20, 2023
  25. 0/9 Minor improvements to CodingGuidelines and SubmittingPatchesJosh Soref via GitGitGadget, Dec 21, 2023
  26. 1/9 CodingGuidelines: move period inside parenthesesJosh Soref via GitGitGadget, Dec 21, 2023
  27. Junio C HamanoDec 21, 2023
  28. Josh SorefDec 21, 2023
  29. Dragan SimicDec 22, 2023
  30. 2/9 CodingGuidelines: write punctuation marksJosh Soref via GitGitGadget, Dec 21, 2023
  31. Junio C HamanoDec 21, 2023
  32. Josh SorefDec 21, 2023
  33. Junio C HamanoDec 21, 2023
  34. 3/9 SubmittingPatches: drop ref to "What's in git.git"Josh Soref via GitGitGadget, Dec 21, 2023
  35. Junio C HamanoDec 21, 2023
  36. 4/9 SubmittingPatches: discourage new trailersJosh Soref via GitGitGadget, Dec 21, 2023
  37. 5/9 SubmittingPatches: update extra tags listJosh Soref via GitGitGadget, Dec 21, 2023
  38. Junio C HamanoDec 21, 2023
  39. Josh SorefDec 21, 2023
  40. 6/9 SubmittingPatches: improve extra tags adviceJosh Soref via GitGitGadget, Dec 21, 2023
  41. Junio C HamanoDec 21, 2023
  42. 7/9 SubmittingPatches: clarify GitHub visualJosh Soref via GitGitGadget, Dec 21, 2023
  43. Junio C HamanoDec 21, 2023
  44. 8/9 SubmittingPatches: clarify GitHub artifact formatJosh Soref via GitGitGadget, Dec 21, 2023
  45. 9/9 SubmittingPatches: hyphenate non-ASCIIJosh Soref via GitGitGadget, Dec 21, 2023
  46. 0/9 Minor improvements to CodingGuidelines and SubmittingPatchesJosh Soref via GitGitGadget, Dec 28, 2023
  47. 1/9 CodingGuidelines: move period inside parenthesesJosh Soref via GitGitGadget, Dec 28, 2023
  48. 2/9 CodingGuidelines: write punctuation marksJosh Soref via GitGitGadget, Dec 28, 2023
  49. 3/9 SubmittingPatches: drop ref to "What's in git.git"Josh Soref via GitGitGadget, Dec 28, 2023
  50. 4/9 SubmittingPatches: discourage new trailersJosh Soref via GitGitGadget, Dec 28, 2023
  51. 5/9 SubmittingPatches: update extra tags listJosh Soref via GitGitGadget, Dec 28, 2023
  52. 6/9 SubmittingPatches: provide tag naming adviceJosh Soref via GitGitGadget, Dec 28, 2023
  53. 7/9 SubmittingPatches: clarify GitHub visualJosh Soref via GitGitGadget, Dec 28, 2023
  54. 8/9 SubmittingPatches: clarify GitHub artifact formatJosh Soref via GitGitGadget, Dec 28, 2023
  55. 9/9 SubmittingPatches: hyphenate non-ASCIIJosh Soref via GitGitGadget, Dec 28, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.