Re: [PATCH 0/8] Minor improvements to CodingGuidelines and SubmittingPatches
- From
Elijah Newren <newren@gmail.com>
- Date
- Dec 20, 2023, 15:43 UTC
- Message-ID
- <CABPp-BF8s-qiXWPMSae0pB+eRLDRO47Fj-7YRfS38SQ+6bBMzA@mail.gmail.com>
- In-Reply-To
- <pull.1623.git.1702975319.gitgitgadget@gmail.com>
On Tue, Dec 19, 2023 at 12:42 AM Josh Soref via GitGitGadget <gitgitgadget@gmail.com> wrote:
Show 9 quoted lines
> > These are a bunch of things I've run into over my past couple of attempts to > contribute to Git. > > * Incremental punctuation/grammatical improvements > * Update extra tags suggestions based on common usage > * drop reference to an article that was discontinued over a decade ago > * update GitHub references > * harmonize non-ASCII while I'm here
I commented on patches 4, 6, and 7 suggesting some changes. Patch 1 is "meh" to me, but it doesn't hurt anything. The other four all look like good cleanups to me.