Re: [PATCH] t3705-add-sparse-checkout: ignore a LF->CRLF warning on Windows

From: Derrick Stolee <stolee@gmail.com>
Date: Jan 18, 2022, 16:17 UTC
Message-ID: <ea4cc086-744b-6fe5-08be-7a9c684da1a3@gmail.com>
In-Reply-To: <df42170b-8659-d496-3454-a4a3ac2827eb@kdbg.org>

On 1/15/2022 9:58 AM, Johannes Sixt wrote:

Show 15 quoted lines

> There are checks that certain `git add` invocations do not produce
> output on stderr. One of them, the original one, uses
> "-c core.autocrlf=input" to ensure that `git add` does not write a
> hint about LF to CRLF conversion to stderr on Windows. A second
> `git add` was added in later patch, but it was forgotten to add
> the same protection. Add it now to let the test pass on Windows.
> 
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
> Am 13.01.22 um 22:12 schrieb Johannes Sixt:
>> is there a reason we don't do this in the test case that you added in
>> 63b60b3add75 ("add: update --chmod to skip sparse paths", 2021-09-24).
>> Notice that the similar git add earlier also sets core.autocrlf.
> 
> Here's a proper patch.

Thanks for this fix. I'm not sure why this fails on your Windows machine but passes the Windows CI builds. Glad to have the fix either way.

> -	git add --sparse --chmod=+x sparse_entry 2>stderr &&
> +	git -c core.autocrlf=input add --sparse --chmod=+x sparse_entry 2>stderr &&

Thanks, -Stolee