Test failure on Windows in t3705-add-sparse-checkout.sh
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Jan 13, 2022, 21:12 UTC
- Message-ID
- <7ed402e0-63cd-2875-b3ac-71c967ccf80a@kdbg.org>
Hi Stolee,
is there a reason we don't do this in the test case that you added in 63b60b3add75 ("add: update --chmod to skip sparse paths", 2021-09-24). Notice that the similar git add earlier also sets core.autocrlf. As the comment indicates, stderr indeed contains a warning about LF->CRLF conversion in my Windows build and fails test_must_be_empty.
diff --git a/t/t3705-add-sparse-checkout.sh b/t/t3705-add-sparse-checkout.sh index 81f3384eee..4fb663e3b4 100755 --- a/t/t3705-add-sparse-checkout.sh +++ b/t/t3705-add-sparse-checkout.sh @@ -181,13 +181,13 @@ test_expect_success 'git add fails outside of sparse-checkout definition' ' # Avoid munging CRLFs to avoid an error message git -c core.autocrlf=input add --sparse sparse_entry 2>stderr && test_must_be_empty stderr && git ls-files --stage >actual && grep "^100644 .*sparse_entry\$" actual && - git add --sparse --chmod=+x sparse_entry 2>stderr && + git -c core.autocrlf=input add --sparse --chmod=+x sparse_entry 2>stderr && test_must_be_empty stderr && git ls-files --stage >actual && grep "^100755 .*sparse_entry\$" actual && git reset &&