git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: phpdoc diff in git -L is not the correct one

From
Grégoire PARIS <postmaster@greg0ire.fr>
Date
Nov 14, 2020, 15:55 UTC
Message-ID
<e666e806-d8c6-0b8d-c583-e4a8ee0ee806@greg0ire.fr>
In-Reply-To
<CAN0heSrU5zzgR_FDZcEopPP2EmSQnraZXO4v8Smx8=fWcXa0uQ@mail.gmail.com>
Hi Martin,
thanks for your answer!
> In the end I think your best option right now is to give explicit line
> numbers for <end> and <start>.

That is indeed what I currently do, I plugged that to vim's visual selection with

   vnoremap <leader>l :<c-u>exe '!git log -L' 
line("'<").','.line("'>").':'.expand('%')<CR>
and it works great!

I was wondering if that was maybe an issue with the PHP regex, but with your explanation I understand a bit more what the issue might be: The man page you are quoting seems to say that the regex can only work on a single line as opposed to a code block (for probably very good reasons), which means there is no hope to include the phpdoc in the regex, or to fix this issue I suppose.

I also suppose the issue is the same for any other language that has documentation above function declarations.

Thanks for taking the time to answer my question.
--
greg0ire
Previous: Martin ÅgrenNext: Martin Ågren
Message 3 of 7 in “phpdoc diff in git -L is not the correct one”
  1. Grégoire PARISNov 14, 2020
  2. Martin ÅgrenNov 14, 2020
  3. Grégoire PARISNov 14, 2020
  4. Martin ÅgrenNov 14, 2020
  5. René ScharfeNov 14, 2020
  6. Grégoire PARISNov 18, 2020
  7. Martin ÅgrenNov 18, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.