Re: [QGIT RFC] Unit tests for QGit

From: Marco Costalba <mcostalba@gmail.com>
Date: Aug 29, 2008, 07:01 UTC
Message-ID: <e5bfff550808290001r168c7edfre926f1bc735f3ad0@mail.gmail.com>
In-Reply-To: <20080828220124.GF15520@efreet.light.src>

On Fri, Aug 29, 2008 at 12:01 AM, Jan Hudec <bulb@ucw.cz> wrote:

Show 7 quoted lines

>
> So, now there is a test infrastructure plus test case to reproduce this
> switching between stgit and non-stgit branch in
> git://repo.or.cz/qgit4/bulb.git (http://repo.or.cz/r/qgit4/bulb.git) with
> whoping 9 commits. Should I send out a patch series, or do you prefer just
> pulling?
>

I prefer to pull.

Show 7 quoted lines

> Now in my opinion the code could use some refactoring rather than just fixing
> the bugs (my long term intent is to add features like topgit support,
> push/pull/merge and other things git-gui can do and such). I'd start with
> the Git initialization sequence. I'll write tests for the new code, but as
> I expect it to have significantly different interface from the old one, I'll
> not try to write tests for the current one.
>

We have following possibilities:

- Pull the code directly in qgit master as soon as there are some new
commits in your branch

- Pull the code in public qgit repo but under a different branch,
let's call' it "next" ;-)

- Waiting for your code has stabilized a bit (testing infrastructure
is very young and for what I have seen from revision history code is
still very 'fluid'), then pull the branch in qgit master directly.

These are my two cents:

Option one could be a little bit misleading for people pulling from qgit repo to get current qgit sources + just fixes.

Option two is doable but is an additional step with an additional maintainer burden, probably the current number of contributors to qgit is not enough to justify such a complex development model.

Perhaps option three it seems the more balanced, also looking at projects git related and with similar size of qgit, as example StGit itself. When let's say Karl has ready a block of patches he sends them all as a series and are applied to StGit master branch.

The only modification I would suggest is that I can pull from you repo directly instead of asking you to send patches to the git list.

I leave up to you when to ask for a pull request, I only ask you to consider that qgit public repo is pulled also by people not interested in the latest development, and they only want a stable qgit, so please ask for a pull when you think stuff is stable enough.

Comments?

Marco