Re: [QGIT RFC] Unit tests for QGit
- From
- Marco Costalba <mcostalba@gmail.com>
- Date
- Aug 19, 2008, 14:53 UTC
- Message-ID
- <e5bfff550808190753t4f99ddb6q83886dbca27dbf03@mail.gmail.com>
- In-Reply-To
- <20080818180048.GA15520@efreet.light.src>
On Mon, Aug 18, 2008 at 7:00 PM, Jan Hudec <bulb@ucw.cz> wrote:
Show 19 quoted lines
> On Sun, Aug 17, 2008 at 21:30:46 +0100, Marco Costalba wrote:
>> On Sun, Aug 17, 2008 at 8:58 PM, Jan Hudec <bulb@ucw.cz> wrote:
>> >
>> > But as I said, I only have basic infrastructure and am currently looking at
>> > what to write tests for and how exactly that test should work. The detection
>> > of git vs. stgit branch (does not work for me)
>>
>> This sounds as a bug. Could you elaborate on that please ?
>>
>>
>> BTW the test for a StGit repo is:
>>
>> isStGIT = run("stg branch", &stgCurBranch); // slow command
>>
>> in function Git::getRefs() , file git_startup.cpp
>
> Yes, I've seen that command. But it returns true for me even when it's not
> a stg branch :-(. I am not sure what the problem there is.
>That's interesting !
The command just runs "stg branch", in my StGit setup this returns an error (some stuff written to stderr) if the directory where it is run is not a StGit stack.
run() just detects the error and returns false.
Could you try to run it from a console and see if you have stuff on stderr ?
Thanks Marco