Re: [PATCH TAKE 2] Avoid a useless prefix lookup in strbuf_expand()

From: Marco Costalba <mcostalba@gmail.com>
Date: Feb 10, 2008, 06:59 UTC
Message-ID: <e5bfff550802092259u4139312cufc4756e9d81f4154@mail.gmail.com>
In-Reply-To: <7vr6fl5yhz.fsf@gitster.siamese.dyndns.org>

On Feb 10, 2008 3:36 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 15 quoted lines

> Marco Costalba <mcostalba@gmail.com> writes:
>
> > Currently the --prett=format prefix is looked up in a
>
> s/prett/&y/;
>
> > New patch with Junio suggestions included.
>
> Hmph, this is a blast from the past.
>
> I do recall pointing out that a rather common "format:%an <%ae>"
> ends up parsing the same line twice, and mentioned we may want
> to memoise the first call's result in the format_commit_context
> structure, but what else did I suggest???
>

Please read thread: "[PATCH RESEND] Avoid a useless prefix lookup in strbuf_expand()"

you will find your suggestions and following answers.

> Anyway, I'll take a look later.  Thanks.
>

Thanks Marco