Re: [PATCH TAKE 2] Avoid a useless prefix lookup in strbuf_expand()

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 10, 2008, 10:52 UTC
Message-ID: <7v4pchgk1h.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <e5bfff550802092259u4139312cufc4756e9d81f4154@mail.gmail.com>

"Marco Costalba" <mcostalba@gmail.com> writes:

Show 12 quoted lines

> On Feb 10, 2008 3:36 AM, Junio C Hamano <gitster@pobox.com> wrote:
> ...
>> I do recall pointing out that a rather common "format:%an <%ae>"
>> ends up parsing the same line twice, and mentioned we may want
>> to memoise the first call's result in the format_commit_context
>> structure, but what else did I suggest???
>>
>
> Please read thread: "[PATCH RESEND] Avoid a useless prefix lookup in
> strbuf_expand()"
>
> you will find your suggestions and following answers.

Yeah, I mentioned the comment needing to be adjusted (which you did in this round), asked a minor question about the code (you answered in the thread), besides pointing out that a rather common "format:%an <%ae>" being inefficient (which you brushed aside, claiming that is a special case).

I've touched-up a few typoes and style glitches and will park this on 'pu' for now.