[PATCH] git stash: one bug and one feature request
- From
- Marco Costalba <mcostalba@gmail.com>
- Date
- Jan 4, 2008, 16:14 UTC
- Message-ID
- <e5bfff550801040814n82f34b2g17c485a207093440@mail.gmail.com>
Currently git-stash writes to stderr also if there is nothing to error out, also it would be very nice ;-) if git 'stash clear command' would support deleting of only one patch, so as example to write
stg stash clear stash@{0}To remove only the last added.
------------------ cut --------------------------
From: Marco Costalba <mcostalba@gmail.com> Date: Fri, 4 Jan 2008 17:08:01 +0100 Subject: [PATCH] git-stash: avoid writing to stderr when is not an error
Otherwise git-stash is unusable by scripts that check stderr to detect fail/success of launched command.
Signed-off-by: Marco Costalba <mcostalba@gmail.com> --- git-stash.sh | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/git-stash.sh b/git-stash.sh index 06cb177..a05a47a 100755 --- a/git-stash.sh +++ b/git-stash.sh @@ -86,7 +86,7 @@ save_stash () { if no_changes then - echo >&2 'No local changes to save' + echo > 'No local changes to save' exit 0 fi test -f "$GIT_DIR/logs/$ref_stash" || @@ -99,7 +99,7 @@ save_stash () { git update-ref -m "$stash_msg" $ref_stash $w_commit || die "Cannot save the current status" - printf >&2 'Saved working directory and index state "%s"\n' "$stash_msg" + printf > 'Saved working directory and index state "%s"\n' "$stash_msg" } have_stash () { @@ -229,7 +229,7 @@ create) if test $# -eq 0 then save_stash && - echo >&2 '(To restore them type "git stash apply")' && + echo > '(To restore them type "git stash apply")' && git-reset --hard else usage
-- 1.5.4.rc2.18.g530e6