git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Big performance regression with --no-color option in git-log

From
MCMarco Costalba <mcostalba@gmail.com>
Date
Sep 29, 2007, 11:29 UTC
Message-ID
<e5bfff550709290429n291968f2md8068a945ff7a79e@mail.gmail.com>
In-Reply-To
<20070929110914.GA32142@artemis.corp>
On 9/29/07, Pierre Habouzit <madcoder@debian.org> wrote:
Show 9 quoted lines
> On Sat, Sep 29, 2007 at 11:01:30AM +0000, Pierre Habouzit wrote:
> > On Sat, Sep 29, 2007 at 10:02:23AM +0000, Marco Costalba wrote:
> > > On today git tree
>
>   Okay for me it's not only from today, and the issue seems to be with
> the fact that we pass options or that we don't... git log --color also
> takes an awful lot of time here, whereas it's my default. Looks like
> diff_opt_parse is called too many times.
>

There was a patch some time ago to fix a similar issue with '-z' option (66e41f7b9912), perhaps the fix could be the same also for --no-color, --color, or other new options that force to actually compute diffs when is not needed.

Marco
Previous: Pierre HabouzitNext: Pierre Habouzit
Message 4 of 12 in “Big performance regression with --no-color option in git-log”
  1. Marco CostalbaSep 29, 2007
  2. Pierre HabouzitSep 29, 2007
  3. Pierre HabouzitSep 29, 2007
  4. Marco CostalbaSep 29, 2007
  5. 1/1 --color and --no-color git-log options don't need diffs to be computed.Pierre Habouzit, Sep 29, 2007
  6. David KastrupSep 29, 2007
  7. Pierre HabouzitSep 29, 2007
  8. Marco CostalbaSep 29, 2007
  9. Marco CostalbaSep 29, 2007
  10. Fix revision log diff setup, avoid unnecessary diff generationLinus Torvalds, Sep 29, 2007
  11. Junio C HamanoSep 29, 2007
  12. Junio C HamanoSep 29, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.