From: Marco Costalba <mcostalba@gmail.com>
Date: Sat, 29 Sep 2007 11:29:30 GMT
Subject: Re: Big performance regression with --no-color option in git-log
Message-ID: <e5bfff550709290429n291968f2md8068a945ff7a79e@mail.gmail.com>
In-Reply-To: <20070929110914.GA32142@artemis.corp>

On 9/29/07, Pierre Habouzit <madcoder@debian.org> wrote:
> On Sat, Sep 29, 2007 at 11:01:30AM +0000, Pierre Habouzit wrote:
> > On Sat, Sep 29, 2007 at 10:02:23AM +0000, Marco Costalba wrote:
> > > On today git tree
>
>   Okay for me it's not only from today, and the issue seems to be with
> the fact that we pass options or that we don't... git log --color also
> takes an awful lot of time here, whereas it's my default. Looks like
> diff_opt_parse is called too many times.
>

There was a patch some time ago to fix a similar issue with '-z'
option (66e41f7b9912), perhaps the fix could be the same also for
--no-color, --color, or other new options that force to actually
compute diffs when is not needed.

Marco