Re: [PATCH] Add --show-size to git log to print message size

From: Marco Costalba <mcostalba@gmail.com>
Date: Jul 25, 2007, 09:38 UTC
Message-ID: <e5bfff550707250238i4fd7926en4c924a0debbb9a3c@mail.gmail.com>
In-Reply-To: <7vabtlf7tf.fsf@assigned-by-dhcp.cox.net>

On 7/25/07, Junio C Hamano <gitster@pobox.com> wrote:

> I've been re-reviewing recent patches, and this is one of them.

Thanks for pushing to pu. Please tell me if you want me to send you a patch to update to what we have discussed, specifically using "length unknown" and changing the name to --show-lengths.

Show 7 quoted lines

> However, I am wondering if this is an intended behaviour...
>
> : git.git master; ./git-log --log-size --abbrev-commit --pretty=oneline \
>   ko/master..master
> 9d468ac... log size 47
> Add --log-size to git log to print message size
> ca193cf... log size 40

Well, the patch should be used to speedup the parsing by tools because you can skip big part of the record and jump directly to the beginning of the next one. So IMHO I don't see a lot of sense in using it together with --pretty=oneline.

Anyway only default options should be guaranteed to behave correctly with all the other options. In general, responsibility for what you see on the screen it's on the tips of user's fingers. IMHO responsibility of git is of not crashing and do not show incorrect info, not that the info should be useful.

Paul, I don't know gitk and Tcl to being able to answer myself, but I would like to know if this new option could be useful also for gitk.

This option, after the first line, gives the size of the following part of the record. Does this allow you to delay the parsing of the biggest part of the commit record?

Author name, date, log title, log message could be read only when it's needed, so that after reading the first couple lines of a commit you can point directly to the beginning of the next one skipping the rest.

Marco