Re: [PATCH] Add --show-size to git log to print message size

From: Sean <seanlkml@sympatico.ca>
Date: Jul 15, 2007, 15:04 UTC
Message-ID: <20070715110415.33692142.seanlkml@sympatico.ca>
In-Reply-To: <e5bfff550707150758h7a9e893frb068d4a9508bc3b2@mail.gmail.com>

On Sun, 15 Jul 2007 16:58:16 +0200 "Marco Costalba" <mcostalba@gmail.com> wrote:

Show 8 quoted lines

> On 7/15/07, Sean <seanlkml@sympatico.ca> wrote:
> >
> > If you only look for ^\0 (ie. first position only) the parsing should
> > be okay.  Not that it helps with the performance issue you're trying
> > to address.
> >
> revisions are streamed, there is only one first revision, all the
> others are linked togheter in a big stream.

Right, but how does that alter the notion that ^\0 is the safe way to test for the "real" NUL terminator?

> Actually I ended up looking for the character after the '\0' (if any)
> to be 'c' that is the beginning of "commit <sha> ....." but it's a bit
> hacky.

Much more hacky than just testing for ^\0. AFAIU, the NUL is guaranteed to come at the start of the line and _all_ other NUL characters are guaranteed to appear somewhere else. Your current test will fail if a "c" happens to follow NUL in the patch text.

Sean