Re: [RFH] QGit: how to cram a patch in a crowded screen

From: Marco Costalba <mcostalba@gmail.com>
Date: May 26, 2007, 20:44 UTC
Message-ID: <e5bfff550705261344l604543e7h64c20c1fc0979f20@mail.gmail.com>
In-Reply-To: <200705261034.53723.andyparkins@gmail.com>

On 5/26/07, Andy Parkins <andyparkins@gmail.com> wrote:

Show 12 quoted lines

>
> For example, the log view widget would show:
>
> <Header>
> <Log Message>
> <Patch>
>
> All visually distinct to improve searching by eye (perhaps including
> clear separators between files patched).  Then the file list could
> include a "<header>" psuedo-file that would jump back to the top of the
> viewer.
>

This seems really gitk like. Not that I don' t like it, but _if_ it's possible I would prefer something a little bit more original.

Show 5 quoted lines

>
> Here's another option, keeping the patch tab, but putting the tab widget
> in the log view window.  That way the list would be visible and you
> would just switch between the log and the patch.
>

Yes. More or less along the lines of an handful of patches I've just pushed to git://git.kernel.org/pub/scm/qgit/qgit4.git

Now user can toggle between revision commit message and patch content with the menu entry 'View->toggle message/diff', or with shortcut 'm' or also with mouse clicking on top right links 'Diff->' and 'Log->'.

There is also a check box in 'Edit->settings' called 'Show always revision message as first' that, if set, let automatically to switch to revision message when browsing on a new revision.

With this, browsing on a repo reading both log message and patch it's a matter of 2 clicks or 2 shortcuts per revision, one for changing revision (and read the log message) and another to view the patch content.

This is a good speedup from before when we needed 3 commands, one for selecting the rev, one for switching to patch tab and viewing the diff and one for switching back to main list.

Comments? like/dislike?

Thanks Marco