Re: [RFH] QGit: how to cram a patch in a crowded screen

From: Andy Parkins <andyparkins@gmail.com>
Date: May 30, 2007, 13:08 UTC
Message-ID: <200705301408.37929.andyparkins@gmail.com>
In-Reply-To: <e5bfff550705261344l604543e7h64c20c1fc0979f20@mail.gmail.com>

On Saturday 2007 May 26, Marco Costalba wrote:

I've been using the latest qgit for a couple of days. Thought I'd comment on the changes.

Show 7 quoted lines

> > All visually distinct to improve searching by eye (perhaps including
> > clear separators between files patched).  Then the file list could
> > include a "<header>" psuedo-file that would jump back to the top of the
> > viewer.
>
> This seems really gitk like. Not that I don' t like it, but _if_ it's
> possible I would prefer something a little bit more original.

I thought of a reason why I like qgit's separation of log and patch. Some revisions have very large patches. In those cases, it's nice to have the choice not to pay for the expensive patch display when all you want is to view the log message.

My vote is definitely for keeping separate log and patch viewer.

> Now user can toggle between revision commit message and patch content
> with the menu entry 'View->toggle message/diff', or with shortcut 'm'
> or also with mouse clicking on top right links 'Diff->' and 'Log->'.

I like the principle; but I'm not sure about the floating "Diff->" and "Log->"; it seems to me that the GUI metaphor for exactly this sort of thing is well established - the tabbed display. Why invent yet another way of switching a window between different views?

> There is also a check box in 'Edit->settings' called 'Show always
> revision message as first' that, if set, let automatically to switch
> to revision message when browsing on a new revision.

I have no objection to this. I can imagine cases when both automatic-switch and leave-it-as-it-is would be what I want - so it has to be an option.

> With this, browsing on a repo reading both log message and patch it's
> a matter of 2 clicks or 2 shortcuts per revision, one for changing
> revision (and read the log message) and another to view the patch
> content.

You don't mention it here, but the change I'm not keen on is the scroll-down to switch feature. Often, I over-scroll to be sure that I have hit the bottom of a scroll box. When I do that with the scroll-to-switch feature, suddenly the view changes. I'm finding it quite disconcerting.

> Comments? like/dislike?

Apart from the minor niggles I've mentioned above; I do like it.
 - It feels more stable - in my day-to-day usage, far less of the screen
   changes, so you don't feel that you're jumping between different modes
 - Being able to see the patch and the revision list at the same time is
   very nice.

While we're on wishes, here's a couple:
 - It's hard to spot the boundaries between files in the the patch viewer.
   It would be great if the
    diff --git a/vserver/Makefile b/vserver/Makefile
    index 2581254..17d8934 100644
   lines had a different coloured background.
 - The margin at the front of the log message lines puts the header block and
   log text at different horizontal positions on the screen.  I think it would
   be nicer if they were at the same position.

Maybe I'll scratch those itches myself; but thought I'd mention them in case you get to them before me :-)

Andy

-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com