Re: [PATCH] Print progress message to stderr, not stdout
- From
- Marco Costalba <mcostalba@gmail.com>
- Date
- Dec 2, 2006, 13:20 UTC
- Message-ID
- <e5bfff550612020520w3ad48a09xfdde63b9050a75cf@mail.gmail.com>
- In-Reply-To
- <20061111121625.8988.45195.stgit@localhost>
On 11/11/06, Karl Hasselström <kha@treskal.com> wrote:
> Printing progress messages to stdout causes them to get mixed up with > the actual output of the program. Using stderr is much better, since > the user can then redirect the two components separately. >
This patch breaks qgit.
GUI interface to stgit pop and push commands is broken because a command that prints to stderr is considered a failing one by qgit.
I would kindly ask you to:
1 - Revert the patch. That would be the best. You can use a prefix to printed message instead, see git pull, something like 'stg: bla bla bla' . In any case, IMHO, using stderr for normal activity logging does not sound like a great idea in general.
2 - At least add a '-v' '--verbose' option that defaults to quiet so to not break back compatibility.
Thanks Marco
P.S: I cannot change the stderr == 'something has gone wrong' behaviour because the interface to git commands works with this, and, BTW, _all_ the git commands respect the behaviour stderr == empty ->