Re: [PATCH] Print progress message to stderr, not stdout
- From
- Catalin Marinas <catalin.marinas@gmail.com>
- Date
- Dec 4, 2006, 09:17 UTC
- Message-ID
- <b0943d9e0612040117y6554b891yaf6eb59d0d52ebf0@mail.gmail.com>
- In-Reply-To
- <e5bfff550612020520w3ad48a09xfdde63b9050a75cf@mail.gmail.com>
On 02/12/06, Marco Costalba <mcostalba@gmail.com> wrote:
Show 19 quoted lines
> On 11/11/06, Karl Hasselström <kha@treskal.com> wrote: > > Printing progress messages to stdout causes them to get mixed up with > > the actual output of the program. Using stderr is much better, since > > the user can then redirect the two components separately. > > This patch breaks qgit. > > GUI interface to stgit pop and push commands is broken because a > command that prints to stderr is considered a failing one by qgit. > > I would kindly ask you to: > > 1 - Revert the patch. That would be the best. You can use a prefix to > printed message instead, see git pull, something like 'stg: bla bla > bla' . In any case, IMHO, using stderr for normal activity logging > does not sound like a great idea in general. > > 2 - At least add a '-v' '--verbose' option that defaults to quiet so > to not break back compatibility.
Since there are other tools relying on a clean stderr, I think I would revert it and add a verbose flag and/or config option. Karl, any thoughts on this (since you sent the patch)?