Re: [PATCH v3 2/2] bundle-uri: add test for bundle-uri clones with tags
- From
- Phillip Wood <phillip.wood123@gmail.com>
- Date
- Mar 19, 2025, 10:33 UTC
- Message-ID
- <e4244e04-d2f3-43ab-88cf-58d9804731b8@gmail.com>
- In-Reply-To
- <d148b14c390f74e86bfa14c05e9e186fdcecbeb8.1742312173.git.gitgitgadget@gmail.com>
Hi Scott
On 18/03/2025 15:36, Scott Chacon via GitGitGadget wrote:
Show 7 quoted lines
> From: Scott Chacon <schacon@gmail.com> > > +test_expect_success 'clone with tags bundle' ' > + git clone --bundle-uri="clone-from-tags/ALL.bundle" \ > + clone-from-tags clone-tags-path && > + git -C clone-tags-path for-each-ref --format="%(refname)" >refs && > + grep "refs/bundles/tags/" refs >actual &&
Thanks for adding this test. Calling "git for-each-ref" followed by "grep" follows the pattern of the existing tests but I'm not sure why they don't just pass the pattern to "for-each-ref" and avoid the extra process.
Do we want to just test for tags or are we really interested to see all the bundle refs created when cloning? This applies to the previous patch as well - we obviously need to change the expected output but I'm not sure changing the ref pattern is necessarily a good idea. After all the point of this series is to create refs under refs/bundles for all the refs in the bundle.
Best Wishes
Phillip
Show 11 quoted lines
> + cat >expect <<-\EOF && > + refs/bundles/tags/A > + refs/bundles/tags/B > + refs/bundles/tags/tag-A > + EOF > + test_cmp expect actual > +' > + > # To get interesting tests for bundle lists, we need to construct a > # somewhat-interesting commit history. > #