git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 0/2] bundle-uri: copy all bundle references ino the refs/bundle space

From
PWPhillip Wood <phillip.wood123@gmail.com>
Date
Apr 25, 2025, 13:53 UTC
Message-ID
<ce33a9ad-e931-4408-92ec-1a898e908c36@gmail.com>
In-Reply-To
<pull.1897.v4.git.git.1745587067.gitgitgadget@gmail.com>
Hi Scott
On 25/04/2025 14:17, Scott Chacon via GitGitGadget wrote:
> Updated the test with Taylor's patch.

Thanks for updating the test, unfortunately the documentation update mentioned in [1] to ensure the refspec in the documentation matches the changes in this series seems to have been overlooked.

Best Wishes
Phillip

[1] https://lore.kernel.org/git/56d8bd34-1301-40d6-8151-f85fb1d7560b@gmail.com/

Show 55 quoted lines
>> bundle-uri: copy all bundle references ino the refs/bundle space
>> bundle-uri: update bundle clone tests with new refspec path
> 
> Scott Chacon (2):
>    bundle-uri: copy all bundle references ino the refs/bundle space
>    bundle-uri: add test for bundle-uri clones with tags
> 
>   bundle-uri.c                |   2 +-
>   t/t5558-clone-bundle-uri.sh | 202 +++++++++++++++++++++---------------
>   2 files changed, 117 insertions(+), 87 deletions(-)
> 
> 
> base-commit: f65182a99e545d2f2bc22e6c1c2da192133b16a3
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1897%2Fschacon%2Fsc-more-bundle-refs-v4
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1897/schacon/sc-more-bundle-refs-v4
> Pull-Request: https://github.com/git/git/pull/1897
> 
> Range-diff vs v3:
> 
>   1:  2ccbfdcc2dc = 1:  6957ee2fed2 bundle-uri: copy all bundle references ino the refs/bundle space
>   2:  d148b14c390 ! 2:  d9a114915a3 bundle-uri: add test for bundle-uri clones with tags
>       @@ Commit message
>            bundle-uri: add test for bundle-uri clones with tags
>        
>            The change to the bundle-uri unbundling refspec now includes tags, so this
>       -    adds a simple test to make sure that tags in a bundle are properly added to
>       -    the cloned repository and will be included in ref negotiation with the
>       -    subsequent fetch.
>       +    adds a very, very simple test to make sure that tags in a bundle are
>       +    properly added to the cloned repository and will be included in ref
>       +    negotiation with the subsequent fetch. ok, now it's right. christ.
>        
>            Signed-off-by: Scott Chacon <schacon@gmail.com>
>        
>       @@ t/t5558-clone-bundle-uri.sh: test_expect_success 'clone with file:// bundle' '
>        +test_expect_success 'clone with tags bundle' '
>        +	git clone --bundle-uri="clone-from-tags/ALL.bundle" \
>        +		clone-from-tags clone-tags-path &&
>       -+	git -C clone-tags-path for-each-ref --format="%(refname)" >refs &&
>       -+	grep "refs/bundles/tags/" refs >actual &&
>       -+	cat >expect <<-\EOF &&
>       -+	refs/bundles/tags/A
>       -+	refs/bundles/tags/B
>       -+	refs/bundles/tags/tag-A
>       -+	EOF
>       ++
>       ++	git -C clone-from-tags for-each-ref --format="%(refname:lstrip=1)" \
>       ++		>expect &&
>       ++	git -C clone-tags-path for-each-ref --format="%(refname:lstrip=2)" \
>       ++		refs/bundles >actual &&
>       ++
>        +	test_cmp expect actual
>        +'
>        +
> 
Previous: Scott ChaconNext: Junio C Hamano
Message 25 of 37 in “bundle-uri: copy all bundle references ino the refs/bundle space”
  1. bundle-uri: copy all bundle references ino the refs/bundle spaceScott Chacon via GitGitGadget, Feb 25, 2025
  2. Junio C HamanoFeb 25, 2025
  3. Derrick StoleeFeb 25, 2025
  4. Scott ChaconMar 1, 2025
  5. Junio C HamanoMar 3, 2025
  6. Derrick StoleeMar 3, 2025
  7. 0/3 bundle-uri: copy all bundle references ino the refs/bundle spaceScott Chacon via GitGitGadget, Mar 1, 2025
  8. 1/3 bundle-uri: copy all bundle references ino the refs/bundle spaceScott Chacon via GitGitGadget, Mar 1, 2025
  9. 2/3 bundle-uri: update bundle clone tests with new refspec pathScott Chacon via GitGitGadget, Mar 1, 2025
  10. 3/3 bundle-uri: add test for bundle-uri clones with tagsScott Chacon via GitGitGadget, Mar 1, 2025
  11. Derrick StoleeMar 3, 2025
  12. 0/2 bundle-uri: copy all bundle references ino the refs/bundle spaceScott Chacon via GitGitGadget, Mar 18, 2025
  13. 1/2 bundle-uri: copy all bundle references ino the refs/bundle spaceScott Chacon via GitGitGadget, Mar 18, 2025
  14. Phillip WoodMar 19, 2025
  15. 2/2 bundle-uri: add test for bundle-uri clones with tagsScott Chacon via GitGitGadget, Mar 18, 2025
  16. Phillip WoodMar 19, 2025
  17. Taylor BlauMar 19, 2025
  18. Toon ClaesApr 14, 2025
  19. Scott ChaconApr 25, 2025
  20. Junio C HamanoMar 21, 2025
  21. 0/2 bundle-uri: copy all bundle references ino the refs/bundle spaceScott Chacon via GitGitGadget, Apr 25, 2025
  22. 1/2 bundle-uri: copy all bundle references ino the refs/bundle spaceScott Chacon via GitGitGadget, Apr 25, 2025
  23. 2/2 bundle-uri: add test for bundle-uri clones with tagsScott Chacon via GitGitGadget, Apr 25, 2025
  24. Scott ChaconApr 25, 2025
  25. Phillip WoodApr 25, 2025
  26. Junio C HamanoApr 25, 2025
  27. 0/2 bundle-uri: copy all bundle references ino the refs/bundle spaceScott Chacon via GitGitGadget, Apr 25, 2025
  28. 2/2 bundle-uri: add test for bundle-uri clones with tagsScott Chacon via GitGitGadget, Apr 25, 2025
  29. 1/2 bundle-uri: copy all bundle references ino the refs/bundle spaceScott Chacon via GitGitGadget, Apr 25, 2025
  30. 0/2 bundle-uri: copy all bundle references ino the refs/bundle spaceScott Chacon via GitGitGadget, Apr 25, 2025
  31. 1/2 bundle-uri: copy all bundle references ino the refs/bundle spaceScott Chacon via GitGitGadget, Apr 25, 2025
  32. 2/2 bundle-uri: add test for bundle-uri clones with tagsScott Chacon via GitGitGadget, Apr 25, 2025
  33. 0/2 bundle-uri: copy all bundle references ino the refs/bundle spaceScott Chacon via GitGitGadget, Apr 25, 2025
  34. 2/2 bundle-uri: add test for bundle-uri clones with tagsScott Chacon via GitGitGadget, Apr 25, 2025
  35. 1/2 bundle-uri: copy all bundle references ino the refs/bundle spaceScott Chacon via GitGitGadget, Apr 25, 2025
  36. Junio C HamanoApr 25, 2025
  37. Phillip WoodApr 29, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.