git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Avoid using non-portable `echo -n` in tests.

From
Mike Ralphson <mike.ralphson@gmail.com>
Date
Nov 3, 2008, 16:30 UTC
Message-ID
<e2b179460811030830t429a469bs3200fade42fecc01@mail.gmail.com>
In-Reply-To
<20081031182456.GC3230@sigill.intra.peff.net>
2008/10/31 Jeff King <peff@peff.net>:
Show 16 quoted lines
> On Fri, Oct 31, 2008 at 01:09:13AM -0400, Brian Gernhardt wrote:
>
>> Not all /bin/sh have a builtin echo that recognizes -n.  Using printf
>> is far more portable.
>>
>> Discovered on OS X 10.5.5 in t4030-diff-textconv.sh and changed in all
>> the test scripts.
>
> Hmph. I think this is a good patch, and there is precedent in the past
> (20fa04ea, 2aad957, 9754563). But I am surprised this was not caught by
> our recent autobuilding project.
>
> However, it seems to work on FreeBSD (which makes it doubly weird that
> it is broken on OS X). On Solaris, the /bin/sh is so horribly broken
> that I have to use bash anyway. Commit 9754563 claims breakage on AIX,
> but it looks like Mike is doing the AIX builds with bash.

I've just retested with AIX's standard sh (ksh) instead of bash and there were only two issues.

Oddly enough, one was with the (original) printfs in t4030-diff-textconv.sh. AIX seems to ship with a perfectly good printf, but if you install the GNU tools from the 'IBM toolbox for AIX' (and prepend them to your PATH) it replaces that printf with one which doesn't grok the "\\1\\n" syntax, but I think wants it to be "\\01\\n".

The other problem is the 'trap exit' one discussed here: http://thread.gmane.org/gmane.comp.version-control.git/92748/focus=92944

Mike
Previous: Johannes Schindelin
Message 15 of 15 in “t4030: Don't use echo -n”
  1. t4030: Don't use echo -nBrian Gernhardt, Oct 30, 2008
  2. Ian HiltOct 30, 2008
  3. Brian GernhardtOct 31, 2008
  4. Avoid using non-portable `echo -n` in tests.Brian Gernhardt, Oct 31, 2008
  5. Junio C HamanoOct 31, 2008
  6. Brian GernhardtOct 31, 2008
  7. Junio C HamanoOct 31, 2008
  8. Steve FollyOct 31, 2008
  9. Shawn O. PearceOct 31, 2008
  10. Jeff KingOct 31, 2008
  11. Pierre HabouzitOct 31, 2008
  12. Jeff KingOct 31, 2008
  13. Francis GaliegueOct 31, 2008
  14. Johannes SchindelinOct 31, 2008
  15. Mike RalphsonNov 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.