Re: [PATCH] t4030: Don't use echo -n

From: Ian Hilt <ian.hilt@gmx.com>
Date: Oct 30, 2008, 23:52 UTC
Message-ID: <20081030235215.GB18221@sys-0.hiltweb.site>
In-Reply-To: <1225404776-51748-1-git-send-email-benji@silverinsanity.com>

On Thu, Oct 30, 2008 at 06:12:56PM -0400, Brian Gernhardt wrote:

> Signed-off-by: Brian Gernhardt <benji@silverinsanity.com>

No commit message???

Show 29 quoted lines

> ---
>  t/t4030-diff-textconv.sh |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/t/t4030-diff-textconv.sh b/t/t4030-diff-textconv.sh
> index 3945731..7ec244f 100755
> --- a/t/t4030-diff-textconv.sh
> +++ b/t/t4030-diff-textconv.sh
> @@ -96,16 +96,15 @@ cat >expect.typechange <<'EOF'
>  -1
>  diff --git a/file b/file
>  new file mode 120000
> -index ad8b3d2..67be421
> +index ad8b3d2..8e4020b
>  --- /dev/null
>  +++ b/file
>  @@ -0,0 +1 @@
>  +frotz
> -\ No newline at end of file
>  EOF
>  # make a symlink the hard way that works on symlink-challenged file systems
>  test_expect_success 'textconv does not act on symlinks' '
> -	echo -n frotz > file &&
> +	echo frotz > file &&
>  	git add file &&
>  	git ls-files -s | sed -e s/100644/120000/ |
>  		git update-index --index-info &&
> -- 
> 1.6.0.3.523.g304d0

This doesn't apply for me. My tip is up-to-date, but it doesn't even have this file it t/.

A little bewildered,

Ian