git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] compat/fopen.c: avoid clobbering the system defined fopen macro

From
Mike Ralphson <mike.ralphson@gmail.com>
Date
May 8, 2008, 07:27 UTC
Message-ID
<e2b179460805080027pf9ff518xf4fcbb248ecac4bf@mail.gmail.com>
In-Reply-To
<4821E81A.4030600@nrlssc.navy.mil>
2008/5/7 Brandon Casey <casey@nrlssc.navy.mil>:
Show 8 quoted lines
>
> Some systems define fopen as a macro based on compiler settings.
> The previous technique for reverting to the system fopen function
> by merely undefining fopen is inadequate in this case. Instead,
> avoid defining fopen entirely when compiling this source file.
>
> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
>
Tested-by: Mike Ralphson <mike@abacus.co.uk>
Both with and without -D_LARGE_FILES. Many thanks.
H.Merijn, is this change also ok for your HP-UX?

I guess there may still be a case for not defining _LARGE_FILES by default on AIX as all the warnings may be off-putting or mask other issues. Maybe instead having a comment for those who need large pack-file support? Will submit amended Makefile patch if there's interest.

Mike
Previous: Brandon CaseyNext: Johannes Sixt
Message 15 of 20 in “Makefile: update the default build options for AIX”
  1. Makefile: update the default build options for AIXMike Ralphson, May 7, 2008
  2. Johannes SixtMay 7, 2008
  3. Mike RalphsonMay 7, 2008
  4. Mike RalphsonMay 7, 2008
  5. Johannes SixtMay 7, 2008
  6. Mike RalphsonMay 7, 2008
  7. Brandon CaseyMay 7, 2008
  8. Mike RalphsonMay 7, 2008
  9. Johannes SixtMay 7, 2008
  10. Brandon CaseyMay 7, 2008
  11. Junio C HamanoMay 7, 2008
  12. Mike RalphsonMay 7, 2008
  13. Brandon CaseyMay 7, 2008
  14. compat/fopen.c: avoid clobbering the system defined fopen macroBrandon Casey, May 7, 2008
  15. Mike RalphsonMay 8, 2008
  16. Johannes SixtMay 8, 2008
  17. Mike RalphsonMay 8, 2008
  18. H.Merijn BrandMay 8, 2008
  19. Mike RalphsonMay 16, 2008
  20. Johannes SixtMay 16, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.