From: Mike Ralphson <mike.ralphson@gmail.com>
Date: Thu, 08 May 2008 07:27:48 GMT
Subject: Re: [PATCH] compat/fopen.c: avoid clobbering the system defined fopen macro
Message-ID: <e2b179460805080027pf9ff518xf4fcbb248ecac4bf@mail.gmail.com>
In-Reply-To: <4821E81A.4030600@nrlssc.navy.mil>

2008/5/7 Brandon Casey <casey@nrlssc.navy.mil>:
>
> Some systems define fopen as a macro based on compiler settings.
> The previous technique for reverting to the system fopen function
> by merely undefining fopen is inadequate in this case. Instead,
> avoid defining fopen entirely when compiling this source file.
>
> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
>

Tested-by: Mike Ralphson <mike@abacus.co.uk>

Both with and without -D_LARGE_FILES. Many thanks.

H.Merijn, is this change also ok for your HP-UX?

I guess there may still be a case for not defining _LARGE_FILES by
default on AIX as all the warnings may be off-putting or mask other
issues. Maybe instead having a comment for those who need large
pack-file support? Will submit amended Makefile patch if there's
interest.

Mike