Re: [PATCH v3] git-svn: allow empty email-address using authors-prog and authors-file
Am 05.04.2018 um 09:51 schrieb Eric Wong:
> Thanks for the update. The patch itself looks good, but I
> noticed one --show-item isn't supported on SVN 1.8.10 for me.
--show-item is indeed a 1.9.0 thing:
https://subversion.apache.org/docs/release-notes/1.9.html#svn-info-item
Show 16 quoted lines
> I've tested the following on both SVN 1.8.10 and 1.9.5:
>
> --- a/t/t9138-git-svn-authors-prog.sh
> +++ b/t/t9138-git-svn-authors-prog.sh
> @@ -83,7 +83,8 @@ test_expect_success 'authors-prog imported user without email' '
> test_expect_success 'imported without authors-prog and authors-file' '
> svn mkdir -m hh --username hh "$svnrepo"/hh &&
> (
> - uuid=$(svn info --show-item=repos-uuid "$svnrepo") &&
> + uuid=$(svn info "$svnrepo" |
> + sed -n "s/^Repository UUID: //p") &&
> cd x &&
> git svn fetch &&
> git rev-list -1 --pretty=raw refs/remotes/git-svn | \
>
> Can you confirm it's OK for you? Thanks.
Looks good, works for me.
Do you squash this patch with with my commit or do you need a reroll?
Andreas Heiduk <asheiduk@gmail.com>