Re: [PATCH v3] git-svn: allow empty email-address using authors-prog and authors-file
- From
- Eric Wong <e@80x24.org>
- Date
- Apr 5, 2018, 07:51 UTC
- Message-ID
- <20180405075113.3y6a5nadijswt7pm@untitled>
- In-Reply-To
- <20180324102046.8840-1-asheiduk@gmail.com>
Thanks for the update. The patch itself looks good, but I noticed one --show-item isn't supported on SVN 1.8.10 for me.
I've tested the following on both SVN 1.8.10 and 1.9.5:
--- a/t/t9138-git-svn-authors-prog.sh +++ b/t/t9138-git-svn-authors-prog.sh @@ -83,7 +83,8 @@ test_expect_success 'authors-prog imported user without email' ' test_expect_success 'imported without authors-prog and authors-file' ' svn mkdir -m hh --username hh "$svnrepo"/hh && ( - uuid=$(svn info --show-item=repos-uuid "$svnrepo") && + uuid=$(svn info "$svnrepo" | + sed -n "s/^Repository UUID: //p") && cd x && git svn fetch && git rev-list -1 --pretty=raw refs/remotes/git-svn | \ Can you confirm it's OK for you? Thanks.