Re: [PATCH] Fix duplicate word typos

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Oct 19, 2024, 10:06 UTC
Message-ID: <e1ee980d-d8d2-4c9c-9a73-ba6af9009ba2@app.fastmail.com>
In-Reply-To: <b50f9706-bb45-4bf0-8d32-59149615301b@mrtux-pc.local>

Hi

I guess it was an intentional choice to not use an “area” in the commit message?

I found this similar patch which used `*` as the area: abcb66c614c (*: fix typos which duplicate a word, 2021-06-11); review here:

https://lore.kernel.org/git/CAPig+cTjjNrU9q8UPm+CRuTKq8_XNc+1z7-3F4bvetBi+NjKeQ@mail.gmail.com/

On Sat, Oct 19, 2024, at 12:37, Sven Strickroth wrote:

> Used regex to find these typos: "(?<!struct )(?<=\s)([a-z]{1,}) \1(?=\s)"

This would be more conventional:

    Used regex to find these typos:

        (?<!struct )(?<=\s)([a-z]{1,}) \1(?=\s)

Either that or code fence (MarkDown style).

>
> Signed-off-by: Sven Strickroth <email@cs-ware.de>

I can confirm that this patch only does that.  Except:

> ---
> […]
> -Suppose that that central repository has this history:
> +Suppose that the central repository has this history:

Here the doubled “that” is replaced with “the” which makes the sentence correct. Good.

There are also no grammatically correct “that that” constructs that have been removed.

> Documentation/RelNotes/2.45.0.txt

I was wondering if typo fixes are done for released-released versions (not going through RC). But the aforementioned patch abcb66c614c does fix a release note or two for some old versions.

-- 
Kristoffer Haugsbakk