Re: [PATCH v2] global: Fix duplicate word typos
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Oct 22, 2024, 05:07 UTC
- Message-ID
- <Zxcy9W0DXnaCR9FJ@pks.im>
- In-Reply-To
- <6ce47185-690d-415e-95c9-06a3b828be29e@cs-ware.de>
On Mon, Oct 21, 2024 at 05:12:26PM +0200, Sven Strickroth wrote:
> Used regex to find these typos:
>
> (?<!struct )(?<=\s)([a-z]{1,}) \1(?=\s)One more nit: the first word after the area should be lower-case. So the subject should be "foo: something" rather than "foo: Something". Other than that the patch looks good to me. I don't really think that this is worth a reroll, but others may disagree with that.
Show 13 quoted lines
> diff --git a/ci/lib.sh b/ci/lib.sh
> index 74b430be23..bfa1fe370b 100755
> --- a/ci/lib.sh
> +++ b/ci/lib.sh
> @@ -62,7 +62,7 @@ trap "end_group 'CI setup'" EXIT
> # something went wrong.
> #
> # We already enabled tracing executed commands earlier. This helps by showing
> -# how # environment variables are set and and dependencies are installed.
> +# how # environment variables are set and dependencies are installed.
> set -e
>
> skip_branch_tip_with_tag () {This one has a stray "#" in it, but it's perfectly fine to not fix this as part of this commit.
Thanks!
Patrick