Re: [PATCH] builtin-prune.c: prune temporary packs in <object_dir>/pack directory
- From
- David Tweed <david.tweed@gmail.com>
- Date
- Sep 23, 2008, 05:37 UTC
- Message-ID
- <e1dab3980809222237v612bfc82n8865ada7f0e4516d@mail.gmail.com>
- In-Reply-To
- <KKSursEoVthEbqc_O82_QIafgU9zgb4bQYP7w6x9ulU85L2Nixe_9g@cipher.nrlssc.navy.mil>
On Tue, Sep 23, 2008 at 12:34 AM, Brandon Casey <casey@nrlssc.navy.mil> wrote:
Show 30 quoted lines
> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
> ---
>
> Re: [PATCH] Do not perform cross-directory renames when creating packs
>
> I think something like this should be applied on top.
>
> -brandon
>
>
> builtin-prune.c | 18 ++++++++++--------
> 1 files changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/builtin-prune.c b/builtin-prune.c
> index c767a0a..fc8be45 100644
> --- a/builtin-prune.c
> +++ b/builtin-prune.c
> @@ -13,7 +13,7 @@ static const char * const prune_usage[] = {
> static int show_only;
> static unsigned long expire;
>
> -static int prune_tmp_object(char *path, const char *filename)
> +static int prune_tmp_object(const char *path, const char *filename)
> {
> const char *fullpath = mkpath("%s/%s", path, filename);
> if (expire) {
> @@ -113,21 +113,19 @@ static void prune_object_dir(const char *path)
> * files begining with "tmp_") accumulating in the
> * object directory.
> */Good spotting. I haven't been remotely involved with git recently but for what little it's worth looks the right thing to me. It'd be nice to modify the patch to keep the comment up to date, something like:
* accumulating in the * object directory (older git versions) or pack directory. */
-- cheers, dave tweed__________________________ david.tweed@gmail.com Rm 124, School of Systems Engineering, University of Reading. "while having code so boring anyone can maintain it, use Python." -- attempted insult seen on slashdot