Re: [PATCH] Do not perform cross-directory renames when creating packs
- From
Linus Torvalds <torvalds@linux-foundation.org>
- Date
- Sep 22, 2008, 17:31 UTC
- Message-ID
- <alpine.LFD.1.10.0809221029240.3265@nehalem.linux-foundation.org>
- In-Reply-To
- <1222104021-28277-1-git-send-email-pasky@suse.cz>
On Mon, 22 Sep 2008, Petr Baudis wrote:
Show 6 quoted lines
>
> A comment on top of create_tmpfile() describes caveats ('can have
> problems on various systems (FAT, NFS, Coda)') that should apply
> in this situation as well. This in the end did not end up solving
> any of my personal problems, but it might be a useful cleanup patch
> nevertheless.Side note: the cross-directory avoidance for loose object creation _did_ seem to clear up the original problems reported on NFS, so yes, this is worth doing. Even if pack-file creation is such a heavy event that I suspect that none of the timing/caching/whatever issues that were present for loose objects really ever trigger in practice.
> Signed-off-by: Petr Baudis <pasky@suse.cz>
Looks obvious enough. So:
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Linus