[PATCH 2/3] imap-send: be more careful when casting to `curl_off_t`
- From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Sep 21, 2025, 12:22 UTC
- Message-ID
- <e1d5a85f70c514749304fe87efde271e9ed5a92c.1758457356.git.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.1974.git.1758457356.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>
When casting a `size_t` to `curl_off_t`, there is a currently uncommon chance that the value can be cut off (`curl_off_t` is supposed to be guaranteed to be 64-bit).
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- imap-send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/imap-send.c b/imap-send.c index 4bd5b8aa0d..26dda7f328 100644 --- a/imap-send.c +++ b/imap-send.c @@ -1721,7 +1721,7 @@ static int curl_append_msgs_to_imap(struct imap_server_conf *server, lf_to_crlf(&msgbuf.buf); curl_easy_setopt(curl, CURLOPT_INFILESIZE_LARGE, - (curl_off_t)(msgbuf.buf.len-prev_len)); + cast_size_t_to_curl_off_t(msgbuf.buf.len-prev_len)); res = curl_easy_perform(curl);
-- gitgitgadget