Re: [PATCH] Use _type constants instead of literal constants
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Apr 2, 2006, 13:41 UTC
- Message-ID
- <e0ok9m$oua$1@sea.gmane.org>
- In-Reply-To
- <20060402130051.GA2933@ebar091.ebar.dtu.dk>
Peter Eriksen wrote:
Show 7 quoted lines
> From: Peter Eriksen <s022018@student.dtu.dk> > Date: Sun Apr 2 14:44:09 2006 +0200 > Subject: [PATCH] Use blob_, commit_, tag_, and tree_type throughout. > > This replaces occurences of "blob", "commit", "tag", and "tree", > where they're really used as type specifiers, which we already > have defined global constants for.
Shouldn't the name of constant rather be e.g. instead of blob_type be type_blob, and similarly for the rest of type constants?
-- Jakub Narebski Warsaw, Poland